Message133246
| Author |
neologix |
| Recipients |
gregory.p.smith, neologix, pitrou, python-dev, rnk, vstinner |
| Date |
2011年04月07日.19:14:52 |
| SpamBayes Score |
1.8312572e-07 |
| Marked as misclassified |
No |
| Message-id |
<BANLkTik06F=qCdwwV3t0HcUsx8OmgnZZaw@mail.gmail.com> |
| In-reply-to |
<E1Q74F2-00025q-GA@dinsdale.python.org> |
| Content |
It seems to have fixed the failure, no ?
I don't know what's the policy regarding syscall parameters check, but
I think it'd be better to check that the timeout passed to select is
not negative, and raise an exception otherwise, instead of silently
storing it into struct timeval (with an overflow) before passing it to
select.
Attached is a patch + test that does just that. |
|