Message133132
| Author |
pitrou |
| Recipients |
Trundle, benjamin.peterson, daniel.urban, eric.araujo, ncoghlan, pitrou, rhettinger |
| Date |
2011年04月06日.14:09:46 |
| SpamBayes Score |
2.327603e-05 |
| Marked as misclassified |
No |
| Message-id |
<1302098983.3700.8.camel@localhost.localdomain> |
| In-reply-to |
<BANLkTi=2MHF0=7e-1+ktjGuz91aND9odVA@mail.gmail.com> |
| Content |
> Why not add fast paths to the generic functions if that's what you're
> concerned about?
>
> It's unexpected for the user of the functions and breaks years of
> tradition. What if someone calls PyList_Append on a custom type that
> doesn't do as they expect and then PyList_GET_ITEM?
>
> It seems like asking for subtle bugs to me. The only correct way to is
> change code that uses these type specific apis to use the generic
> ones.
I agree with Benjamin.
IIRC we already have a bunch of fast paths in abstract.c. |
|