Message 132820 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	pitrou
Recipients	MizardX, antlong, asvetlov, eric.araujo, mdehoon, nadeem.vawda, niemeyer, pitrou, rhettinger, wrobell, xuanji
Date	2011年04月02日.23:45:48
SpamBayes Score	8.306786e-09
Marked as misclassified	No
Message-id	<1301787945.3494.38.camel@localhost.localdomain>
In-reply-to	<1301787262.79.0.2065758755.issue5863@psf.upfronthosting.co.za>

Content
> The tests for readline() and readlines() expect a TypeError if size is None. > Calling size.__index__() in this case raises an AttributeError instead. Should I > change the tests to expect an AttributeError? Alternatively, something like this > would more closely match the behaviour of the old code: > > try: > size = size.__index__() > except AttributeError: > raise TypeError("Integer argument expected") Ah, you're right, TypeError should be raised.

Content

> The tests for readline() and readlines() expect a TypeError if size is None.
> Calling size.__index__() in this case raises an AttributeError instead. Should I
> change the tests to expect an AttributeError? Alternatively, something like this
> would more closely match the behaviour of the old code:
> 
> try:
> size = size.__index__()
> except AttributeError:
> raise TypeError("Integer argument expected")
Ah, you're right, TypeError should be raised.

History
Date	User	Action	Args
2011年04月02日 23:45:49	pitrou	set	recipients: + pitrou, rhettinger, niemeyer, mdehoon, wrobell, nadeem.vawda, eric.araujo, asvetlov, MizardX, antlong, xuanji
2011年04月02日 23:45:48	pitrou	link	issue5863 messages
2011年04月02日 23:45:48	pitrou	create

homepage