Message132502
| Author |
sdaoden |
| Recipients |
amaury.forgeotdarc, georg.brandl, r.david.murray, sdaoden, twouters |
| Date |
2011年03月29日.19:11:03 |
| SpamBayes Score |
5.588957e-11 |
| Marked as misclassified |
No |
| Message-id |
<1301425866.04.0.648168019076.issue11700@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
This new patch adheres your suggestion.
Now all implemented operations perform
a "file is open at all" check and raise
ValueError if not, which somewhat reflects
what i've seen when i was looking into fileio.c.
My questions:
- shouldn't _ProxyFile inherit from
a real Python I/O class, for example IOBase?
Like this it would stand in a line where it belongs.
I could do that (not much missing for that).
- I have no idea of the test framework. The last hour
i tried to adjust test_mailbox.py a bit, but it's hard.
It's not about design and it's not about algorithm. Uff.
I could nonetheless add some cases to yet existing
test functions and change another one. But this needs
a real eye on it!
(For example: is there a AssertNoRaises?) |
|