Message 132034 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	eric.araujo
Recipients	brett.cannon, eric.araujo, pitrou, r.david.murray
Date	2011年03月24日.21:27:36
SpamBayes Score	0.00015466628
Marked as misclassified	No
Message-id	<1301002057.59.0.0188286470982.issue10966@psf.upfronthosting.co.za>

Content
I’m probably the one with the least regrtest knowledge among us, but I like the general idea of moving the compat info from one huge dict into the tests themselves. It looks more readable and maintainable. The new tests for test.support looks good. I have a reputation to maintain, so here are some nits: - "FS encoding" would be clearer as "filesystem encoding". - The argument names "required_on" and "optional" are not symmetrical. - The indentation is hard to read here: +pty = import_module('pty', + optional=['win32', 'os2emx', 'freebsd4', 'freebsd5', 'freebsd6', + 'freebsd7', 'freebsd8'])

Content

I’m probably the one with the least regrtest knowledge among us, but I like the general idea of moving the compat info from one huge dict into the tests themselves. It looks more readable and maintainable.
The new tests for test.support looks good.
I have a reputation to maintain, so here are some nits:
- "FS encoding" would be clearer as "filesystem encoding".
- The argument names "required_on" and "optional" are not symmetrical.
- The indentation is hard to read here:
+pty = import_module('pty',
+ optional=['win32', 'os2emx', 'freebsd4', 'freebsd5', 'freebsd6',
+ 'freebsd7', 'freebsd8'])

History
Date	User	Action	Args
2011年03月24日 21:27:37	eric.araujo	set	recipients: + eric.araujo, brett.cannon, pitrou, r.david.murray
2011年03月24日 21:27:37	eric.araujo	set	messageid: <1301002057.59.0.0188286470982.issue10966@psf.upfronthosting.co.za>
2011年03月24日 21:27:37	eric.araujo	link	issue10966 messages
2011年03月24日 21:27:36	eric.araujo	create

homepage