Message130797
| Author |
orsenthil |
| Recipients |
calvin, orsenthil, r.david.murray, santoso.wijaya |
| Date |
2011年03月14日.08:30:07 |
| SpamBayes Score |
4.606231e-05 |
| Marked as misclassified |
No |
| Message-id |
<20110314083000.GB4388@kevin> |
| In-reply-to |
<1300091132.6.0.822845253121.issue11467@psf.upfronthosting.co.za> |
| Content |
Santoso, Quick review comments:
1. The patch looks good.
2. I would use a temporary 'throw-away' variable instead of _, but don't bother to change it, before committing I shall take care.
3. Important - Did you find any regression with the earlier builds, also could you run the full test suite to ensure that all tests pass? |
|