Message127383
| Author |
eli.bendersky |
| Recipients |
brett.cannon, eli.bendersky, giampaolo.rodola, ncoghlan, r.david.murray |
| Date |
2011年01月29日.05:22:07 |
| SpamBayes Score |
0.00010011035 |
| Marked as misclassified |
No |
| Message-id |
<1296278527.81.0.489936707258.issue11049@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Giampaolo,
The patch looks good. Some minor comments below:
* class TestCase(unittest.TestCase): -> why not give the test class a more useful name?
* import_fresh_module is tested similarly to import_module - can't a test be added that it indeed performs its "special sauce"?
* test_DirsOnSysPath: you may want to use assertIn and assertNotIn here. [these were added to Python in 3.1]
* test_python_is_optimized: you may want to use assertIsInstance here. |
|