Message 126574 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	belopolsky
Recipients	belopolsky, lavajoe, r.david.murray
Date	2011年01月19日.23:00:42
SpamBayes Score	6.3267817e-07
Marked as misclassified	No
Message-id	<1295478048.58.0.337818535593.issue10947@psf.upfronthosting.co.za>

Content
David, Can you weigh in on this? I am -1 on improving Internaldate2tuple(). I think the module should provide a function that would return an aware datetime object instead of a timetuple. The proposed patch will make error reporting from Internaldate2tuple() inconsistent: invalid bytes result in None return while non-ASCII characters in strings would raise an encoding error. While I don't like the "if not mo: return None" logic, if compatibility with 2.x is the goal, encoding errors should be caught and converted to return None.

Content

David,
Can you weigh in on this?
I am -1 on improving Internaldate2tuple(). I think the module should provide a function that would return an aware datetime object instead of a timetuple.
The proposed patch will make error reporting from Internaldate2tuple() inconsistent: invalid bytes result in None return while non-ASCII characters in strings would raise an encoding error. While I don't like the "if not mo: return None" logic, if compatibility with 2.x is the goal, encoding errors should be caught and converted to return None.

History
Date	User	Action	Args
2011年01月19日 23:00:48	belopolsky	set	recipients: + belopolsky, r.david.murray, lavajoe
2011年01月19日 23:00:48	belopolsky	set	messageid: <1295478048.58.0.337818535593.issue10947@psf.upfronthosting.co.za>
2011年01月19日 23:00:42	belopolsky	link	issue10947 messages
2011年01月19日 23:00:42	belopolsky	create

homepage