Message 126015 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	rosslagerwall
Recipients	giampaolo.rodola, loewis, pitrou, rosslagerwall
Date	2011年01月11日.15:52:53
SpamBayes Score	1.3583675e-08
Marked as misclassified	No
Message-id	<1294761175.82.0.659665118309.issue10882@psf.upfronthosting.co.za>

Content
I've just tried it against r87935 and it applies cleanly. Perhaps you didn't apply the patch correctly (it requires "-p1" since it was a Mercurial diff), try: patch -p1 < sendfile_v2.patch With regards to the different arguments, I don't know if that's acceptable or not or if there is a better way. Since you can have mmap.mmap() with differing args between Windows & Unix, maybe it is acceptable. And, Python exposes differing functionality via the posix module since the available functions differs widely between platforms.

Content

I've just tried it against r87935 and it applies cleanly.
Perhaps you didn't apply the patch correctly (it requires "-p1" since it was a Mercurial diff), try:
 patch -p1 < sendfile_v2.patch
With regards to the different arguments, I don't know if that's acceptable or not or if there is a better way. Since you can have mmap.mmap() with differing args between Windows & Unix, maybe it is acceptable. And, Python exposes differing functionality via the posix module since the available functions differs widely between platforms.

History
Date	User	Action	Args
2011年01月11日 15:52:55	rosslagerwall	set	recipients: + rosslagerwall, loewis, pitrou, giampaolo.rodola
2011年01月11日 15:52:55	rosslagerwall	set	messageid: <1294761175.82.0.659665118309.issue10882@psf.upfronthosting.co.za>
2011年01月11日 15:52:53	rosslagerwall	link	issue10882 messages
2011年01月11日 15:52:53	rosslagerwall	create

homepage