Message125377
| Author |
loewis |
| Recipients |
amaury.forgeotdarc, brian.curtin, janglin, loewis, pitrou, schmir, vstinner |
| Date |
2011年01月04日.22:40:28 |
| SpamBayes Score |
0.00016995559 |
| Marked as misclassified |
No |
| Message-id |
<4D23A1DC.7040508@v.loewis.de> |
| In-reply-to |
<1294178571.15.0.908274924182.issue9566@psf.upfronthosting.co.za> |
| Content |
> MvL> If you are absolutely certain that a cast cannot possibly truncate,
> MvL> add a comment explaining why that is.
>
> Ah yes, sorry, I forgot to add a comment: done in r87746.
But the comment is actually wrong: It says
len <= buf_size <= INT_MAX (see above)
however, len > buf_size may happen, after this code:
if (len > buf_size) {
PyErr_Format(PyExc_ValueError,
"read() returned too much data: "
"%i bytes requested, %zd returned",
buf_size, len);
goto finally;
} |
|