Message125367
| Author |
loewis |
| Recipients |
amaury.forgeotdarc, brian.curtin, janglin, loewis, pitrou, schmir, vstinner |
| Date |
2011年01月04日.21:47:09 |
| SpamBayes Score |
1.8792702e-05 |
| Marked as misclassified |
No |
| Message-id |
<1294177631.26.0.639346888504.issue9566@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
haypo: please avoid introducing explicit casts (such as the one in pyexpat.c). Use SAFECASTs instead. If you are absolutely certain that a cast cannot possibly truncate, add a comment explaining why that is. In the specific case, I think it actually *is* possible that the cast truncates, because the case that read() returned too many bytes is incorrectly handled (it should set len to -1). |
|