Message 120918 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	vstinner
Recipients	hfuru, vstinner
Date	2010年11月10日.14:27:36
SpamBayes Score	4.139428e-05
Marked as misclassified	No
Message-id	<1289399368.31.0.51116551548.issue10308@psf.upfronthosting.co.za>

Content
r86399 fixes the code checking PyUnicode_AsWideChar() failure. The following change is useless, it cannot overflow: - if (n + k > MAXPATHLEN) + if (k > MAXPATHLEN - n) k = MAXPATHLEN - n; n and k maximum values are MAXPATHLEN (and the maximum value of MAXPATHLEN is 4096), whereas n and k type maximum values are at least 2^31.

Content

r86399 fixes the code checking PyUnicode_AsWideChar() failure.
The following change is useless, it cannot overflow:
- if (n + k > MAXPATHLEN)
+ if (k > MAXPATHLEN - n)
 k = MAXPATHLEN - n;
n and k maximum values are MAXPATHLEN (and the maximum value of MAXPATHLEN is 4096), whereas n and k type maximum values are at least 2^31.

History
Date	User	Action	Args
2010年11月10日 14:29:28	vstinner	set	recipients: + vstinner, hfuru
2010年11月10日 14:29:28	vstinner	set	messageid: <1289399368.31.0.51116551548.issue10308@psf.upfronthosting.co.za>
2010年11月10日 14:27:36	vstinner	link	issue10308 messages
2010年11月10日 14:27:36	vstinner	create

homepage