homepage

Further replies. There’s still one comment in test_register you haven’t
addressed yet.
Tarek, I’d like to have your decision about one line in the upload
command. (Don’t read the diff in this mail, it’s incomplete, go to
Rietveld.) Thanks in advance.
http://codereview.appspot.com/2874041/diff/2001/cmd.py
File cmd.py (right):
http://codereview.appspot.com/2874041/diff/2001/cmd.py#newcode55
cmd.py:55: :param distutils.dist.Distribution dist: distribution to work
with
> Including this in another patch is too much work to ever happen.
We’ll have to revert it before committing then.
Something like "*dist* is an instance of blah".
http://codereview.appspot.com/2874041/diff/2001/command/upload.py
File command/upload.py (right):
http://codereview.appspot.com/2874041/diff/2001/command/upload.py#newcode53
command/upload.py:53: if not self.username and
self.distribution.username:
This is a crazy case. PyPI won’t allow it to pass, so I’m okay with it.
 Tarek, what do you think?
http://codereview.appspot.com/2874041/diff/2001/tests/test_register.py
File tests/test_register.py (right):
http://codereview.appspot.com/2874041/diff/2001/tests/test_register.py#newcode165
tests/test_register.py:165: inputs = RawInputs('1', 'tarek', 'n')
It looks like you’re replying to "username" and "save your login" but
not "password".
http://codereview.appspot.com/2874041/