This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
| Author | eric.araujo |
|---|---|
| Recipients | eric.araujo, techtonik |
| Date | 2010年11月08日.17:17:14 |
| SpamBayes Score | 0.15730649 |
| Marked as misclassified | No |
| Message-id | <90e6ba476adb7467fe04948dcbf2@google.com> |
| In-reply-to |
| Content | |
|---|---|
Looks globally good to me. http://codereview.appspot.com/2874041/diff/2001/cmd.py File cmd.py (right): http://codereview.appspot.com/2874041/diff/2001/cmd.py#newcode55 cmd.py:55: :param distutils.dist.Distribution dist: distribution to work with Please don’t include unrelated changes in your patch. Also, Python does not use :param: in docstrings. http://codereview.appspot.com/2874041/diff/2001/command/upload.py File command/upload.py (right): http://codereview.appspot.com/2874041/diff/2001/command/upload.py#newcode53 command/upload.py:53: if not self.username and self.distribution.username: I’d prefer a clearer comparison, please use "is [not] None" and parens. http://codereview.appspot.com/2874041/ |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2011年02月09日 22:46:54 | eric.araujo | unlink | issue10361 messages |
| 2010年11月08日 17:17:17 | eric.araujo | set | recipients: + eric.araujo |
| 2010年11月08日 17:17:14 | eric.araujo | link | issue10361 messages |
| 2010年11月08日 17:17:14 | eric.araujo | create | |