Message 120159 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	jelie
Recipients	jelie
Date	2010年11月01日.20:16:04
SpamBayes Score	1.9778664e-08
Marked as misclassified	No
Message-id	<1288642567.32.0.7785411032.issue10282@psf.upfronthosting.co.za>

Content
I believe the case of "IMPLEMENTATION" should be treated differently. It is not helpful at all to split the argument. It is meant to be a text string and ['INN', '2.6.0', '(20101101', 'prelease)'] does not have much meaning... Suggestion: if line.startswith("IMPLEMENTATION"): name, tokens = line.split(None, 1) else: name, tokens = line.split() or something else, though I do not believe another keyword will begin with "IMPLEMENTATION"... Besides, shouldn't it be checked that the line is not empty, before splitting it?

Content

I believe the case of "IMPLEMENTATION" should be treated differently.
It is not helpful at all to split the argument. It is meant to be a
text string and ['INN', '2.6.0', '(20101101', 'prelease)'] does not
have much meaning...
Suggestion:
 if line.startswith("IMPLEMENTATION"):
 name, *tokens = line.split(None, 1)
 else:
 name, *tokens = line.split()
or something else, though I do not believe another keyword will begin with "IMPLEMENTATION"...
Besides, shouldn't it be checked that the line is not empty, before splitting it?

History
Date	User	Action	Args
2010年11月01日 20:16:07	jelie	set	recipients: + jelie
2010年11月01日 20:16:07	jelie	set	messageid: <1288642567.32.0.7785411032.issue10282@psf.upfronthosting.co.za>
2010年11月01日 20:16:06	jelie	link	issue10282 messages
2010年11月01日 20:16:04	jelie	create

homepage