Message 119992 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	bbrazil
Recipients	bbrazil
Date	2010年10月30日.14:59:05
SpamBayes Score	2.7075835e-06
Marked as misclassified	No
Message-id	<1288450748.11.0.919591582507.issue10253@psf.upfronthosting.co.za>

Content
fileio_init will leak a fd if you open a file for append that isn't seekable. We should close this fd before returning the failure. The attached patch fixes this and a resource warning in the tests, but I'm unsure if it'd be better to use internal_close. I'd want the error from the seek rather than any potential error from the close, so I think this is okay. Regrtest is happy.

Content

fileio_init will leak a fd if you open a file for append that isn't seekable. We should close this fd before returning the failure.
The attached patch fixes this and a resource warning in the tests, but I'm unsure if it'd be better to use internal_close. I'd want the error from the seek rather than any potential error from the close, so I think this is okay.
Regrtest is happy.

History
Date	User	Action	Args
2010年10月30日 14:59:08	bbrazil	set	recipients: + bbrazil
2010年10月30日 14:59:08	bbrazil	set	messageid: <1288450748.11.0.919591582507.issue10253@psf.upfronthosting.co.za>
2010年10月30日 14:59:06	bbrazil	link	issue10253 messages
2010年10月30日 14:59:06	bbrazil	create

homepage