Message119716
| Author |
belopolsky |
| Recipients |
belopolsky, djc, r.david.murray |
| Date |
2010年10月27日.15:20:54 |
| SpamBayes Score |
2.1113555e-11 |
| Marked as misclassified |
No |
| Message-id |
<AANLkTi=Cxb1P6CP02ghZ_CkWg_9KfN7s3f+76Tp0nMQi@mail.gmail.com> |
| In-reply-to |
<1288190939.59.0.450104223274.issue10213@psf.upfronthosting.co.za> |
| Content |
On Wed, Oct 27, 2010 at 10:48 AM, R. David Murray
<report@bugs.python.org> wrote:
..
> My first reaction to this was the feeling that the error message was correct and appropriate :)
>
That was my first reaction as well.
> But it is true that since it doesn't represent a failure in Python itself it shouldn't be reported as a failure.
> The test should be skipped, though, rather than just doing a continue, so that it appears as a skip in verbose
> test output. (You do that by raising a unittest.SkipTest exception.)
I am not so sure about that. Changing fail to skip will pretty much
disable the test. There is no assert in the test. Maybe we should
replace the fail on ValueError with a real round-trip test? Now, if
the test has prerequisites such as set timezone, it should be skipped
entirely if prerequisites are not met and not after strptime fails.
Is 'TZ' in os.environ a prerequisite on all system? |
|