Message 118978 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	hfuru
Recipients	hfuru
Date	2010年10月17日.20:14:53
SpamBayes Score	0.0018841901
Marked as misclassified	No
Message-id	<1287346495.15.0.809946654619.issue10133@psf.upfronthosting.co.za>

Content
Neither conn_recv_string() nor its callers free *newbuffer on error. The promotion rules break negative 'res' for 64-bit Py_ssize_t in the (ulength <= buflength) branch: res = -1 ==> (UINT32)-1 ==> Py_ssize_t 0xffffffff instead of -1. While I'm writing: The _conn_recvall() calls can be factored out of the if(). This patch applies to both 3.2a3 and 2.7. However, the patched failure cases are untested: I do not know how to test them. It passes make test.

Content

Neither conn_recv_string() nor its callers free *newbuffer on error.
The promotion rules break negative 'res' for 64-bit Py_ssize_t
in the (ulength <= buflength) branch:
res = -1 ==> (UINT32)-1 ==> Py_ssize_t 0xffffffff instead of -1.
While I'm writing: The _conn_recvall() calls can be factored out
of the if().
This patch applies to both 3.2a3 and 2.7. However, the patched failure
cases are untested: I do not know how to test them. It passes make test.

History
Date	User	Action	Args
2010年10月17日 20:14:55	hfuru	set	recipients: + hfuru
2010年10月17日 20:14:55	hfuru	set	messageid: <1287346495.15.0.809946654619.issue10133@psf.upfronthosting.co.za>
2010年10月17日 20:14:54	hfuru	link	issue10133 messages
2010年10月17日 20:14:53	hfuru	create

homepage