Message 118939 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	pitrou
Recipients	doko, exarkun, lekma, loewis, nvetoshkin, pitrou
Date	2010年10月17日.12:22:09
SpamBayes Score	2.8368864e-05
Marked as misclassified	No
Message-id	<1287318131.67.0.815151794729.issue10115@psf.upfronthosting.co.za>

Content
There would need to be some tests. Also, this last part of the patch looks strange: @@ -3001,6 +3072,10 @@ PyErr_SetString(PyExc_ValueError, "can't use invalid socket value"); return -1; +#ifdef HAVE_ACCEPT4 + /* These flags are not inherited after accept / + type &= ~(SOCK_NONBLOCK & SOCK_CLOEXEC); +#endif / HAVE_ACCEPT4 */ What is it meant for? And why does it come right after a "return" statement?

Content

There would need to be some tests.
Also, this last part of the patch looks strange:
@@ -3001,6 +3072,10 @@
 PyErr_SetString(PyExc_ValueError,
 "can't use invalid socket value");
 return -1;
+#ifdef HAVE_ACCEPT4
+ /* These flags are not inherited after accept */
+ type &= ~(SOCK_NONBLOCK & SOCK_CLOEXEC);
+#endif /* HAVE_ACCEPT4 */
What is it meant for? And why does it come right after a "return" statement?

History
Date	User	Action	Args
2010年10月17日 12:22:11	pitrou	set	recipients: + pitrou, loewis, doko, exarkun, lekma, nvetoshkin
2010年10月17日 12:22:11	pitrou	set	messageid: <1287318131.67.0.815151794729.issue10115@psf.upfronthosting.co.za>
2010年10月17日 12:22:10	pitrou	link	issue10115 messages
2010年10月17日 12:22:09	pitrou	create

homepage