Message 118564 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	loewis
Recipients	eric.araujo, gyorkop, loewis
Date	2010年10月13日.19:06:03
SpamBayes Score	5.6398857e-08
Marked as misclassified	No
Message-id	<1286996765.98.0.548913741854.issue10066@psf.upfronthosting.co.za>

Content
Éric, I think the patch needs some rework. First, it is incorrect/incomplete: please see the Char definition for a complete list of characters that must be excluded. This then raises a Unicode vs. bytes issue, where invalid Unicode characters must be prohibited before the string actually being encoded (since apply the regex to the encoded string is not practical). The other side of the bytes vs. string issue is that the bytes really ought to be in self.encoding, which doesn't get checked, either. And then, it lacks tests.

Content

Éric, I think the patch needs some rework. First, it is incorrect/incomplete: please see the Char definition for a complete list of characters that must be excluded. This then raises a Unicode vs. bytes issue, where invalid Unicode characters must be prohibited before the string actually being encoded (since apply the regex to the encoded string is not practical).
The other side of the bytes vs. string issue is that the bytes really ought to be in self.encoding, which doesn't get checked, either.
And then, it lacks tests.

History
Date	User	Action	Args
2010年10月13日 19:06:06	loewis	set	recipients: + loewis, eric.araujo, gyorkop
2010年10月13日 19:06:05	loewis	set	messageid: <1286996765.98.0.548913741854.issue10066@psf.upfronthosting.co.za>
2010年10月13日 19:06:03	loewis	link	issue10066 messages
2010年10月13日 19:06:03	loewis	create

homepage