Message112036
| Author |
eric.araujo |
| Recipients |
eric.araujo, jafo, meatballhat, tarek, titus |
| Date |
2010年07月30日.01:31:05 |
| SpamBayes Score |
0.047913812 |
| Marked as misclassified |
No |
| Message-id |
<1280453468.27.0.35532416262.issue8591@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I have six changesets that make progressive improvements on cosmetic things, so that the code gets more readable. You can start with http://bitbucket.org/Merwok/distutils2-killsetup/changeset/5e2906cabeab and follow the parent links.
The other changes you made include changing the config file (+1, except with a simpler "mkpkg" section name), touching up the input/print code, and improving the helper methods (e.g. using codecs.open, using a simple string template instead of a lot of file.write). I had an illumination: We shouldn’t code input/print things but use the cmd module. That will be my next move, then I’ll look at your other code improvements (they will be a bit hard to spot, since your diff basically rewrites every line so I can’t easily see the changes made inside one function, but I’ll manage). |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2010年07月30日 01:31:08 | eric.araujo | set | recipients:
+ eric.araujo, jafo, titus, tarek, meatballhat |
| 2010年07月30日 01:31:08 | eric.araujo | set | messageid: <1280453468.27.0.35532416262.issue8591@psf.upfronthosting.co.za> |
| 2010年07月30日 01:31:06 | eric.araujo | link | issue8591 messages |
| 2010年07月30日 01:31:05 | eric.araujo | create |
|