Message111884
| Author |
ezio.melotti |
| Recipients |
Asheesh.Laroia, amaury.forgeotdarc, brian.curtin, christian.heimes, ezio.melotti, georg.brandl, r.david.murray, rarana, terry.reedy |
| Date |
2010年07月29日.02:03:47 |
| SpamBayes Score |
1.5536962e-05 |
| Marked as misclassified |
No |
| Message-id |
<1280369031.39.0.799627865978.issue6538@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
The patch looks good to me, but I'm not sure if it's a good idea to use _sre.SRE_*. I think these are implementation details and even if they should be mentioned somewhere, they "clutter" the doc IMHO.
> 2. I believe it is the policy that the 3.x docs 'start fresh' with 3.0.
Yes, they should be removed.
> 3. [...] In any case, removing the default value while changing 'group=0' to '[group]' seems wrong.
If it's possible to specify a default value the [] should be avoided. |
|