Message110196
| Author |
pitrou |
| Recipients |
csernazs, pitrou, skrah |
| Date |
2010年07月13日.14:00:57 |
| SpamBayes Score |
9.8272605e-05 |
| Marked as misclassified |
No |
| Message-id |
<1279029655.3236.34.camel@localhost.localdomain> |
| In-reply-to |
<20100713132701.GA12463@yoda.bytereef.org> |
| Content |
> I wasn't really precise. The test fails on Linux, but for a different reason.
> Linux legitimately sets ENAMETOOLONG and raises OSError. This only becomes
> apparent when using 4098 in the test.
>
> Solaris, on the other hand, does not even raise, since it keeps setting
> ERANGE and thus does not leave the loop in posix_getcwd(). IOW, only the
> fix in posixmodule.c allows the test to fail properly in the first place.
Ok. Still, silencing all OSErrors in test_posix is much too broad. The
code should check for expected error codes, possibly depending on the
OS.
> If you prefer, of course it's possible to be conservative and make the new
> version of posix_getcwd() Solaris specific.
I think this would be the most reasonable solution for 2.7, indeed. |
|