Message 110084 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	pitrou
Recipients	Christophe Simonis, ajaksu2, andybuckley, brian.curtin, christian.heimes, edemaine, eric.araujo, iki, meatballhat, michael.foord, pitrou, tarek, tleeuwenburg@gmail.com
Date	2010年07月12日.11:47:12
SpamBayes Score	0.001209431
Marked as misclassified	No
Message-id	<1278935234.53.0.867571365335.issue444582@psf.upfronthosting.co.za>

Content
Some comments on the patch: - shouldn't getdir_id use os.path.normcase() rather than manually switch on `windows`? - the patch adds lots of names at the top-level which aren't part of the public API ("windows", "getdir_id", "defpath", "defpath_ext"). They should probably start with an underscore. - if PATH is updated after shutil is first imported, the changes won't get picked up. Is it desired?

Content

Some comments on the patch:
- shouldn't getdir_id use os.path.normcase() rather than manually switch on `windows`?
- the patch adds lots of names at the top-level which aren't part of the public API ("windows", "getdir_id", "defpath", "defpath_ext"). They should probably start with an underscore.
- if PATH is updated after shutil is first imported, the changes won't get picked up. Is it desired?

History
Date	User	Action	Args
2010年07月12日 11:47:14	pitrou	set	recipients: + pitrou, edemaine, christian.heimes, ajaksu2, tarek, eric.araujo, Christophe Simonis, andybuckley, tleeuwenburg@gmail.com, michael.foord, brian.curtin, meatballhat, iki
2010年07月12日 11:47:14	pitrou	set	messageid: <1278935234.53.0.867571365335.issue444582@psf.upfronthosting.co.za>
2010年07月12日 11:47:12	pitrou	link	issue444582 messages
2010年07月12日 11:47:12	pitrou	create

homepage