Message 107210 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	vstinner
Recipients	vstinner
Date	2010年06月06日.19:11:08
SpamBayes Score	0.010814613
Marked as misclassified	No
Message-id	<1275851470.16.0.472008534505.issue8926@psf.upfronthosting.co.za>

Content
PyArg_ParseTuple("t") calls PyObject_GetBuffer() and then raise an error if arg->ob_type->tp_as_buffer->bf_releasebuffer is not NULL. I think that it should call PyBuffer_Release(&view) before raising the error, or simply check bf_releasebuffer before calling PyObject_GetBuffer(). getbuffer() calls PyObject_GetBuffer() and then raise an error if the buffer is not contiguous. I think that it should call PyBuffer_Release() before the error. Attached patch fixes both errors. Tell me if I'm wrong :-)

Content

PyArg_ParseTuple("t") calls PyObject_GetBuffer() and then raise an error if arg->ob_type->tp_as_buffer->bf_releasebuffer is not NULL. I think that it should call PyBuffer_Release(&view) before raising the error, or simply check bf_releasebuffer before calling PyObject_GetBuffer().
getbuffer() calls PyObject_GetBuffer() and then raise an error if the buffer is not contiguous. I think that it should call PyBuffer_Release() before the error.
Attached patch fixes both errors.
Tell me if I'm wrong :-)

History
Date	User	Action	Args
2010年06月06日 19:11:10	vstinner	set	recipients: + vstinner
2010年06月06日 19:11:10	vstinner	set	messageid: <1275851470.16.0.472008534505.issue8926@psf.upfronthosting.co.za>
2010年06月06日 19:11:09	vstinner	link	issue8926 messages
2010年06月06日 19:11:08	vstinner	create

homepage