Message106081
| Author |
mark.dickinson |
| Recipients |
mark.dickinson, meador.inge |
| Date |
2010年05月19日.16:58:30 |
| SpamBayes Score |
1.8855711e-05 |
| Marked as misclassified |
No |
| Message-id |
<1274288312.01.0.172623138585.issue8748@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Okay, this patch looks fine to me for py3k. More tests would be great, but I don't see much other cleaning up that needs doing.
Just one thing: I'd make the 'i.imag == 0.0' check earlier, so that the potentially expensive long-to-float check can be avoided where appropriate.
I'd also move the 'op != Py_EQ && op != Py_NE' check before the first TO_COMPLEX, though I realize that this is orthogonal to the issue under discussion; the definition seems cleaner that way, though I don't think it makes any difference to the behaviour. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2010年05月19日 16:58:32 | mark.dickinson | set | recipients:
+ mark.dickinson, meador.inge |
| 2010年05月19日 16:58:32 | mark.dickinson | set | messageid: <1274288312.01.0.172623138585.issue8748@psf.upfronthosting.co.za> |
| 2010年05月19日 16:58:30 | mark.dickinson | link | issue8748 messages |
| 2010年05月19日 16:58:30 | mark.dickinson | create |
|