Message105232
| Author |
mark.dickinson |
| Recipients |
belopolsky, mark.dickinson |
| Date |
2010年05月07日.21:33:17 |
| SpamBayes Score |
0.00040651605 |
| Marked as misclassified |
No |
| Message-id |
<1273267998.95.0.353205378693.issue8644@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Thanks for the patch! Comments, in increasing order of fussiness:
(1) there should be a Py_DECREF(total_microseconds) in the case that the "PyLong_FromLong(1000000L)" call fails
(2) in the docstring, replace 'loose' by 'lose'
(3) also in the docstring, I suggest replacing "280 years" by "270 years": "td == timedelta(seconds = td.total_seconds())" starts failing at 2**33 seconds (around 272.2 Julian years) rather than 2**53 microseconds. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2010年05月07日 21:33:19 | mark.dickinson | set | recipients:
+ mark.dickinson, belopolsky |
| 2010年05月07日 21:33:18 | mark.dickinson | set | messageid: <1273267998.95.0.353205378693.issue8644@psf.upfronthosting.co.za> |
| 2010年05月07日 21:33:17 | mark.dickinson | link | issue8644 messages |
| 2010年05月07日 21:33:17 | mark.dickinson | create |
|