homepage

This function in asyncore is buggy:
def _strerror(err):
 res = os.strerror(err)
 if res == 'Unknown error':
 res = errorcode[err]
 return res
- os.strerror may throw ValueError depending on the os, or return a string saying something like: "Unknown error 1234".
- os.strerror never returns "Unknown error" for me, so "Unknown error <err>" is always returned for me (Linux 2.6.32)
- if os.strerrror failed, it's likely that it wont be in errno.errcode either
Maybe it should be written like this:
def _strerror(err):
 try:
 return strerror(err)
 except ValueError:
 return "Unknown error {0}".format(err)