Message104403
| Author |
brian.curtin |
| Recipients |
brian.curtin, enolte, loewis, stutzbach, techtonik |
| Date |
2010年04月28日.03:29:31 |
| SpamBayes Score |
0.017897544 |
| Marked as misclassified |
No |
| Message-id |
<1272425373.99.0.997817301596.issue2810@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
test_changing_value is giving inconsistent results when the _winreg.c patch is not applied. It mostly fails on QueryValue, sometimes on EnumValue, and about 1/10 times the test does not fail at all. Ideally the tests should not use threads -- can the same thing be tested without a thread? It seems like the issue isn't related to concurrency, but maybe I missed something.
With _winreg.c patched, the tests seem to pass, but I haven't run that as much as I have the unpatched version.
winreg_test.pach
- test_changing_value (assuming we need do this as a thread)
-- I'd just use HKEY_CURRENT_USER directly instead of storing it locally
-- done doesn't need to be a list, it could just be the True/False
-- the if/else could be shortened to `s = "x" if short else "x"*2000`
- test_long_key
-- After SetValue I'd just call EnumKey(key, 0) since you can only ever have that value to use. The loop isn't really used. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2010年04月28日 03:29:34 | brian.curtin | set | recipients:
+ brian.curtin, loewis, techtonik, stutzbach, enolte |
| 2010年04月28日 03:29:33 | brian.curtin | set | messageid: <1272425373.99.0.997817301596.issue2810@psf.upfronthosting.co.za> |
| 2010年04月28日 03:29:31 | brian.curtin | link | issue2810 messages |
| 2010年04月28日 03:29:31 | brian.curtin | create |
|