Message103794
| Author |
pitrou |
| Recipients |
pitrou, vstinner |
| Date |
2010年04月20日.23:45:38 |
| SpamBayes Score |
1.3647289e-06 |
| Marked as misclassified |
No |
| Message-id |
<1271807139.9.0.378140861036.issue8477@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Some comments:
- your ssl_convert_filename() function has a strange signature
- using PyByteArray_AsString() is wrong, we release the GIL later and the buffer could be reallocated, leading to a crash; the right approach is to use PyObject_GetBuffer() and later PyBuffer_Release()
- as such, your function could simply return the bytes/bytearray PyObject *, and not fill the char * pointer
- adding tests for both the bytes and unicode cases would be nice |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2010年04月20日 23:45:40 | pitrou | set | recipients:
+ pitrou, vstinner |
| 2010年04月20日 23:45:39 | pitrou | set | messageid: <1271807139.9.0.378140861036.issue8477@psf.upfronthosting.co.za> |
| 2010年04月20日 23:45:38 | pitrou | link | issue8477 messages |
| 2010年04月20日 23:45:38 | pitrou | create |
|