Message 102729 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	eric.smith
Recipients	eric.smith, techtonik
Date	2010年04月09日.15:53:17
SpamBayes Score	5.7149387e-09
Marked as misclassified	No
Message-id	<1270828399.77.0.951802067258.issue8355@psf.upfronthosting.co.za>

Content
This would be easier to review if the patch were generated with 'svn diff'. That said, it looks okay in concept to me, although I couldn't apply it and test without manually mucking with the patch. 2.6 is in bugfix mode, so it can't be changed there. I added 3.2, since it should probably agree with 2.7. What I can't answer is if this should actually be done. I don't know if anyone's relying on the current behavior. I do agree that unified diffs are more desirable.

Content

This would be easier to review if the patch were generated with 'svn diff'.
That said, it looks okay in concept to me, although I couldn't apply it and test without manually mucking with the patch.
2.6 is in bugfix mode, so it can't be changed there. I added 3.2, since it should probably agree with 2.7.
What I can't answer is if this should actually be done. I don't know if anyone's relying on the current behavior. I do agree that unified diffs are more desirable.

History
Date	User	Action	Args
2010年04月09日 15:53:19	eric.smith	set	recipients: + eric.smith, techtonik
2010年04月09日 15:53:19	eric.smith	set	messageid: <1270828399.77.0.951802067258.issue8355@psf.upfronthosting.co.za>
2010年04月09日 15:53:17	eric.smith	link	issue8355 messages
2010年04月09日 15:53:17	eric.smith	create

homepage