Message101988
| Author |
lemburg |
| Recipients |
ajaksu2, amaury.forgeotdarc, harobed, lemburg |
| Date |
2010年03月31日.10:28:19 |
| SpamBayes Score |
5.3488347e-06 |
| Marked as misclassified |
No |
| Message-id |
<4BB323C1.7070107@egenix.com> |
| In-reply-to |
<1270029621.31.0.495333713529.issue8260@psf.upfronthosting.co.za> |
| Content |
Amaury Forgeot d'Arc wrote:
>
> Amaury Forgeot d'Arc <amauryfa@gmail.com> added the comment:
>
> Buffering applies when writing, not when reading a file.
>
> There is indeed a problem in codecs.py: after a readline(), read() will return the content of the internal buffer, and not more.
>
> The "size" parameter is a hint, and should not be used to decide whether the character buffer is enough to satisfy the read() request.
> Patch is attached, with test.
Agreed.
The patch looks good except the if-line should read:
if chars >= 0 and len(self.charbuffer) >= chars:
...
Thanks,
--
Marc-Andre Lemburg
eGenix.com
________________________________________________________________________
::: Try our new mxODBC.Connect Python Database Interface for free ! ::::
eGenix.com Software, Skills and Services GmbH Pastor-Loeh-Str.48
D-40764 Langenfeld, Germany. CEO Dipl.-Math. Marc-Andre Lemburg
Registered at Amtsgericht Duesseldorf: HRB 46611
http://www.egenix.com/company/contact/ |
|