This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2010年07月19日 16:21 by belopolsky, last changed 2022年04月11日 14:57 by admin.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| datetime_doc_remove_east_west.diff | henriquebastos, 2010年11月20日 19:11 | review | ||
| datetime_doc_remove_east_west_2.diff | rbp, 2010年11月20日 20:46 | review | ||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 31697 | open | slateny, 2022年03月05日 16:55 | |
| Messages (24) | |||
|---|---|---|---|
| msg110774 - (view) | Author: Alexander Belopolsky (belopolsky) * (Python committer) | Date: 2010年07月19日 16:21 | |
I am opening this to supersede issue7229. See discussion following msg107148. In many places offsets representing the difference between local time and UTC are described as minutes or seconds east or west of UTC. This is not correct because UTC is not a place and minutes and seconds don't measure distance in this context. Replacing UTC with the Prime Meridian will not fix that because some regions in the western hemisphere use positive offsets from UTC. or example, Madrid is at 3° 42' West, but uses Central European Time which is UTC+1. I believe geographical references in the python documentation are irrelevant. What users are interested in is how to convert local time to UTC and UTC to local time rather than what is the sign of time.timezone in Madrid. I suggest the following wording for time.timezone description: time.timezone: The number of seconds one must add to the local time to arrive at UTC. Similarly, tzinfo.utcoffset() can be defined as "Returns timedelta one must add to UTC to arrive at local time." |
|||
| msg110905 - (view) | Author: anatoly techtonik (techtonik) | Date: 2010年07月20日 14:46 | |
On Mon, Jul 19, 2010 at 7:21 PM, Alexander Belopolsky <report@bugs.python.org> wrote: > > I suggest the following wording for time.timezone description: > > time.timezone: The number of seconds one must add to the local time to arrive at UTC. Makes sense. I can't see any other real explanation for -7200 value if I am in +2 UTC timezone. > Similarly, tzinfo.utcoffset() can be defined as "Returns timedelta one must add to UTC to arrive at local time." I believe the correct convention is "Return timedelta...". Another concern - if UTC is 0 reference point then there is no reason to add something to it - you just can say - "Return timedelta equal to local UTC offset." |
|||
| msg110910 - (view) | Author: Alexander Belopolsky (belopolsky) * (Python committer) | Date: 2010年07月20日 15:29 | |
On Tue, Jul 20, 2010 at 10:46 AM, anatoly techtonik <report@bugs.python.org> wrote: > .. Another > concern - if UTC is 0 reference point then there is no reason to add > something to it - you just can say - "Return timedelta equal to local > UTC offset." No, UTC is not a 0 reference point, it is a time scale. UTC offset is the value that is used to translate between time expressed in UTC and local time. To make an analogy, expressing time in UTC is like expressing temperature in Kelvin scale. You need to subtract 273 from the value in oK to arrive at the value in oC. Documenting utcoffset() as "Return timedelta equal to local UTC offset." is almost circular. It does not explain whether it has to be added or subtracted from UTC to arrive at local time. |
|||
| msg110911 - (view) | Author: Tim Peters (tim.peters) * (Python committer) | Date: 2010年07月20日 15:39 | |
FYI, I like the change. As I recall it, the current wording was just to avoid saying "ahead of UTC" or "behind UTC" (which was the original wording). Technically pure or not, I never saw anyone get truly confused by "East of UTC" or "West of UTC", but I fully that what people really want to know is what to do with the thing (add or subtract it). |
|||
| msg110912 - (view) | Author: Fred Drake (fdrake) (Python committer) | Date: 2010年07月20日 15:47 | |
On Tue, Jul 20, 2010 at 10:46 AM, anatoly techtonik <techtonik@gmail.com> wrote: > I believe the correct convention is "Return timedelta...". This is handled inconsistently in the documentation; I'm hoping the current maintainers reinforce the "Returns ..." structure. The documentation is descriptive, not an external specification. -Fred |
|||
| msg110916 - (view) | Author: anatoly techtonik (techtonik) | Date: 2010年07月20日 16:08 | |
> Documenting utcoffset() as "Return timedelta equal to local UTC > offset." is almost circular. It does not explain whether it has to be > added or subtracted from UTC to arrive at local time. Ok. Sold. >> I believe the correct convention is "Return timedelta...". > > This is handled inconsistently in the documentation; I'm hoping the > current maintainers reinforce the "Returns ..." structure. The > documentation is descriptive, not an external specification. http://www.python.org/dev/peps/pep-0257/#one-line-docstrings I've took the convention from here. I thought docs are generated from docstrings. |
|||
| msg110917 - (view) | Author: Fred Drake (fdrake) (Python committer) | Date: 2010年07月20日 16:13 | |
On Tue, Jul 20, 2010 at 12:08 PM, anatoly techtonik <report@bugs.python.org> wrote: > I've took the convention from here. I thought docs are generated from > docstrings. They're not, but I don't think that really matters. Older documentation used the imperative form consistently, but that's shifted over time. (I, at least, think that's a good thing.) I don't think it really matters with regard to this issue. |
|||
| msg110918 - (view) | Author: Alexander Belopolsky (belopolsky) * (Python committer) | Date: 2010年07月20日 16:14 | |
On Tue, Jul 20, 2010 at 11:39 AM, Tim Peters <report@bugs.python.org> wrote: >.. As I recall it, the current wording was just to avoid saying "ahead of UTC" or "behind UTC" (which was the original wording). Interesting. I actually like the original wording better. For me, "my watch is 6 hours behind UTC" makes it clear that when the Big Ben clock shows tea time (18:00), my watch displays noon (17:00 - 6:00 = 12:00.) I wonder if east/west is somehow more natural for native speakers of English. I would really like to hear more from the international audience. When it comes to measuring time there are many interesting traditions that don't translate well between nations. For example, I've heard that in the Far East, the future is considered to be behind because you can see the past but you cannot see the future. If this is the notion that you are used to, time being ahead or behind can be truly confusing. |
|||
| msg110919 - (view) | Author: Alexander Belopolsky (belopolsky) * (Python committer) | Date: 2010年07月20日 16:18 | |
On Tue, Jul 20, 2010 at 12:14 PM, Alexander Belopolsky <report@bugs.python.org> wrote: .. > Interesting. I actually like the original wording better. For me, > "my watch is 6 hours behind UTC" makes it clear that when the Big Ben > clock shows tea time (18:00), my watch displays noon (17:00 - 6:00 = > 12:00.) I was too excited to add Alice in Wonderland humor to my post that did not get the math right. :-) The above should read 18:00 - 6:00 = 12:00, of course. Or was it five o'clock after all? |
|||
| msg110926 - (view) | Author: Alexander Belopolsky (belopolsky) * (Python committer) | Date: 2010年07月20日 17:19 | |
On Tue, Jul 20, 2010 at 12:08 PM, anatoly techtonik <report@bugs.python.org> wrote: .. > Ok. Sold. Good. All we need now is just a patch. :-) |
|||
| msg121726 - (view) | Author: Henrique Bastos (henriquebastos) | Date: 2010年11月20日 19:10 | |
Here goes a patch to replace east/west references on datetime documentation. As spoken with fdrake we think the datetime documentation could be improved extracting the timezone subclassing details to specific section. We'll be filling a new issue for that patch. |
|||
| msg121727 - (view) | Author: Henrique Bastos (henriquebastos) | Date: 2010年11月20日 19:11 | |
Here goes a patch to replace east/west references on datetime documentation. As spoken with fdrake we think the datetime documentation could be improved extracting the timezone subclassing details to specific section. We'll be filling a new issue for that patch. |
|||
| msg121728 - (view) | Author: Alexander Belopolsky (belopolsky) * (Python committer) | Date: 2010年11月20日 19:18 | |
LGTM |
|||
| msg121745 - (view) | Author: Alexander Belopolsky (belopolsky) * (Python committer) | Date: 2010年11月20日 19:56 | |
On the second reading, I have a few issues with the patch. 1. Please run makepatcheck. There are whitespace issues in datetime.rst. 2. In docstrings, you remove the information about the sign. I would not mind leaving docstrings the way they are. Otherwise, please add a short sentence explaining the sign of utcoffset and dst. 3. "This represents the offset in minutes that must be added to the local time zone to follow DST rules." This unclear. DST offset is added to the "standard time", not "local time zone". (I am not sure if "standard time" is defined in the manual, though.) Also, "in minutes" is not necessary - timedelta carries the units. You can add that only offsets that are multiples of a minute are supported. |
|||
| msg121751 - (view) | Author: Henrique Bastos (henriquebastos) | Date: 2010年11月20日 20:12 | |
To clarify: 1) "we" means henriquebastos, rbp, Rodolpho.Eckhardt. 2) Mentioning fdrake I was trying to say that we followed his suggestion to only submit the specific changes on this patch, leaving further documentation changes to another issue. Sorry about any inconvenience. |
|||
| msg121765 - (view) | Author: Rodrigo Bernardo Pimentel (rbp) (Python committer) | Date: 2010年11月20日 20:46 | |
1. Done (it's on the patch I'm uploading). Sorry. 3. Ok, we've rewritten that sentence. As Henrique mentioned, we're working on a larger patch to make datetime documentation clearer, and we can include a definition of "standard time" there. 2. I assume you're talking about sentences like "(negative for west of UTC)". We removed that wording because it inevitably leads to associating UTC with a geographical reference. Even if we disregard that, it's not true that "utcoffset is negative west of UTC", since it will we zero for for UTC-1 (and even +1 for places physically "west of UTC" but at timezone UTC+0) when DST is effective. It seems that any sentence we add to that effect will be simply restating the definitions of UTC, timezones and DST (and their mathematical relationships). That is, "utcoffset will be negative when dt.tzinfo + dst() is negative". Perhaps we could include a more detailed discusion about the sign of utcoffset() on the larger doc patch I've mentioned? Or do you have any suggestions? |
|||
| msg126020 - (view) | Author: Alexander Belopolsky (belopolsky) * (Python committer) | Date: 2011年01月11日 16:26 | |
I've noticed that the time module docstring handles this issue rather nicely:
>>> help('time')
...
timezone -- difference in seconds between UTC and local standard time
altzone -- difference in seconds between UTC and local DST time
We can use similar language for utcoffset(): "difference between local time and UTC expressed as a timedelta".
|
|||
| msg185565 - (view) | Author: Mark Lawrence (BreamoreBoy) * | Date: 2013年03月30日 15:16 | |
Well, we have a patch and it's been discussed here and on #7229, so can we take this forward? |
|||
| msg221916 - (view) | Author: Alexander Belopolsky (belopolsky) * (Python committer) | Date: 2014年06月29日 23:28 | |
This seems to be touching the same areas as #9305. |
|||
| msg257935 - (view) | Author: Martin Panter (martin.panter) * (Python committer) | Date: 2016年01月10日 20:33 | |
Assuming you meant Issue 8810, yes these patches would collide with each other. I am yet to look at the patches, but I gess they should be merged. |
|||
| msg304934 - (view) | Author: Cheryl Sabella (cheryl.sabella) * (Python committer) | Date: 2017年10月24日 18:38 | |
Would one of the original authors of the patches like to create a GitHub pull request for this issue? |
|||
| msg332985 - (view) | Author: Ajay Mahato (Ajay Mahato) | Date: 2019年01月04日 16:10 | |
I would like to work on this issue. Please assign this to me. |
|||
| msg333045 - (view) | Author: Ajay Mahato (Ajay Mahato) | Date: 2019年01月05日 07:40 | |
I am taking up this issue. |
|||
| msg361715 - (view) | Author: Chris Wilcox (crwilcox) * | Date: 2020年02月10日 20:03 | |
Are you still working on this Ajay Mahato? |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:04 | admin | set | github: 53551 |
| 2022年03月05日 16:55:35 | slateny | set | nosy:
+ slateny pull_requests: + pull_request29817 |
| 2020年02月14日 09:16:24 | ravipudi | set | nosy:
+ ravipudi |
| 2020年02月10日 20:03:06 | crwilcox | set | nosy:
+ crwilcox messages: + msg361715 |
| 2019年01月05日 07:40:56 | Ajay Mahato | set | messages: + msg333045 |
| 2019年01月04日 16:10:57 | Ajay Mahato | set | nosy:
+ Ajay Mahato messages: + msg332985 |
| 2018年07月05日 15:42:37 | p-ganssle | set | nosy:
+ p-ganssle |
| 2017年10月24日 18:38:20 | cheryl.sabella | set | nosy:
+ cheryl.sabella messages: + msg304934 |
| 2016年02月08日 04:36:40 | ncoghlan | link | issue8810 superseder |
| 2016年01月10日 20:33:05 | martin.panter | set | nosy:
+ martin.panter dependencies: + TZ offset description is unclear in docs, - Don't use east/west of UTC in date/time documentation messages: + msg257935 |
| 2016年01月10日 20:33:05 | martin.panter | unlink | issue9305 dependencies |
| 2014年06月29日 23:28:03 | belopolsky | set | assignee: belopolsky -> messages: + msg221916 |
| 2014年06月29日 23:26:34 | belopolsky | set | dependencies: + Don't use east/west of UTC in date/time documentation |
| 2014年06月29日 23:26:34 | belopolsky | link | issue9305 dependencies |
| 2014年02月03日 18:37:43 | BreamoreBoy | set | nosy:
- BreamoreBoy |
| 2013年03月30日 15:16:52 | BreamoreBoy | set | nosy:
+ BreamoreBoy messages: + msg185565 |
| 2011年01月11日 16:26:27 | belopolsky | set | nosy:
tim.peters, fdrake, belopolsky, techtonik, rbp, docs@python, henriquebastos, Rodolpho.Eckhardt messages: + msg126020 |
| 2010年11月20日 20:46:25 | rbp | set | files:
+ datetime_doc_remove_east_west_2.diff messages: + msg121765 |
| 2010年11月20日 20:12:31 | henriquebastos | set | messages: + msg121751 |
| 2010年11月20日 19:56:10 | belopolsky | set | messages:
+ msg121745 stage: commit review -> patch review |
| 2010年11月20日 19:26:02 | belopolsky | set | assignee: docs@python -> belopolsky stage: needs patch -> commit review |
| 2010年11月20日 19:18:25 | belopolsky | set | messages: + msg121728 |
| 2010年11月20日 19:11:14 | henriquebastos | set | files:
+ datetime_doc_remove_east_west.diff keywords: + patch messages: + msg121727 |
| 2010年11月20日 19:10:54 | henriquebastos | set | nosy:
+ henriquebastos, Rodolpho.Eckhardt messages: + msg121726 |
| 2010年11月20日 17:35:37 | rbp | set | nosy:
+ rbp |
| 2010年07月20日 17:19:50 | belopolsky | set | messages: + msg110926 |
| 2010年07月20日 16:18:31 | belopolsky | set | messages: + msg110919 |
| 2010年07月20日 16:14:38 | belopolsky | set | messages: + msg110918 |
| 2010年07月20日 16:13:19 | fdrake | set | messages: + msg110917 |
| 2010年07月20日 16:08:06 | techtonik | set | messages: + msg110916 |
| 2010年07月20日 15:47:14 | fdrake | set | nosy:
+ fdrake messages: + msg110912 |
| 2010年07月20日 15:39:36 | tim.peters | set | nosy:
+ tim.peters messages: + msg110911 |
| 2010年07月20日 15:29:05 | belopolsky | set | messages: + msg110910 |
| 2010年07月20日 14:46:12 | techtonik | set | nosy:
+ techtonik messages: + msg110905 |
| 2010年07月19日 16:42:17 | belopolsky | link | issue7229 superseder |
| 2010年07月19日 16:42:05 | belopolsky | set | dependencies: + Manual entry for time.daylight can be misleading |
| 2010年07月19日 16:21:43 | belopolsky | create | |