homepage

Running:
py3d -m trace -C . --listfuncs trace_target.py
Where py3d points to a freshly compiled Python 3 trunk interpreter, results in an error: 
functions called:
Traceback (most recent call last):
 File "/home/eliben/python_src/eliben-py3k/Lib/runpy.py", line 160, in _run_module_as_main
 "__main__", fname, loader, pkg_name)
 File "/home/eliben/python_src/eliben-py3k/Lib/runpy.py", line 73, in _run_code
 exec(code, run_globals)
 File "/home/eliben/python_src/eliben-py3k/Lib/trace.py", line 816, in <module>
 main()
 File "/home/eliben/python_src/eliben-py3k/Lib/trace.py", line 813, in main
 results.write_results(missing, summary=summary, coverdir=coverdir)
 File "/home/eliben/python_src/eliben-py3k/Lib/trace.py", line 260, in write_results
 for filename, modulename, funcname in sorted(calls.keys()):
NameError: global name 'calls' is not defined
--------------
With Python 2.x it runs fine. The cause is probably a bug introduced during the porting to Python 3. The relevant piece of code in the write_results() method in trace.py is:
 if self.calledfuncs:
 print()
 print("functions called:")
 for filename, modulename, funcname in sorted(calls.keys()):
 print(("filename: %s, modulename: %s, funcname: %s"
 % (filename, modulename, funcname)))
The 'calls' variable in the loop isn't defined anywhere. Previously (in 2.6) this same chunk of code looked like this:
 if self.calledfuncs:
 print
 print "functions called:"
 calls = self.calledfuncs.keys()
 calls.sort()
 for filename, modulename, funcname in calls:
 print ("filename: %s, modulename: %s, funcname: %s"
 % (filename, modulename, funcname))
Which aliases 'calls' to 'self.calledfuncs.keys()'
------
Once this is confirmed as a bug, I will be happy to submit a patch that solves the problem.

The fix is simple one-liner, so here's a patch.

Looking at the 2.x code, that is the obvious fix. I think this ready to commit.

Trace.py does not appear to have a test module to add a test case to.
test_trace.py currently tests the line trace facility turned on with sys.settrace. I will inquire on pydev about this. "Does trace ..."

I've opened issue 9315 to address the lack of unit tests for trace.py
I think that this should be committed regardless, since it fixes a serious bug in the module. Adding unit tests can take time, and is less critical.

This is clearly an artifact of porting to 3.x. In 2.x the code was
 calls = self.calledfuncs.keys()
 calls.sort()
 for filename, modulename, funcname in calls:
which was translated to
 for filename, modulename, funcname in sorted(calls.keys()):
missing the calls assignment. I am going to commit this patch.

Committed with a minor change to meet 80-character line limit.
See r82997 (r82999 for 3.1).