This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2010年06月23日 17:14 by belopolsky, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue9063.diff | belopolsky, 2010年07月07日 04:49 | Documentation patch | review | |
| Messages (5) | |||
|---|---|---|---|
| msg108462 - (view) | Author: Alexander Belopolsky (belopolsky) * (Python committer) | Date: 2010年06月23日 17:14 | |
With python started at the root of the source tree and TZ=US/Eastern in the environment,
>>> exec(open('Doc/includes/tzinfo-examples.py').read())
>>> import os
>>> os.environ['TZ']
'US/Eastern'
>>> from datetime import *
>>> x = datetime(2010, 11, 7, 5, tzinfo=timezone.utc)
>>> print(x, x.astimezone(Local), x.astimezone(Eastern))
2010年11月07日 05:00:00+00:00 2010年11月07日 01:00:00-04:00 2010年11月07日 01:00:00-05:00
>>> x.astimezone(Local).dst() == x.astimezone(Eastern).dst()
False
Note that according to my understanding of the long comment at the end of datetimemodule.c, zone conversion from UTC is a well defined operation unless there is a bug in tzinfo subclass implementation.
|
|||
| msg108464 - (view) | Author: Alexander Belopolsky (belopolsky) * (Python committer) | Date: 2010年06月23日 17:37 | |
The result given when Eastern tzinfo object is used is clearly wrong. The timezone shift should not change the actual time, but >>> x == x.astimezone(Eastern) False while >>> x == x.astimezone(Local) True |
|||
| msg108470 - (view) | Author: Alexander Belopolsky (belopolsky) * (Python committer) | Date: 2010年06月23日 18:29 | |
Let's establish what is the correct wall clock sequence around EDT to EST transition:
>>> import time
>>> def print_time(s):
... tt = time.localtime(s)
... print(time.strftime('%c %z %Z', tt))
x = datetime(2010, 11, 7, 5)
>>> s = (x - datetime(1970, 1, 1))//timedelta(seconds=1)
>>> for i in range(-3600, 5000, 1200):
... print_time(s + i)
...
Sun Nov 7 00:00:00 2010 -0400 EDT
Sun Nov 7 00:20:00 2010 -0400 EDT
Sun Nov 7 00:40:00 2010 -0400 EDT
Sun Nov 7 01:00:00 2010 -0400 EDT
Sun Nov 7 01:20:00 2010 -0400 EDT
Sun Nov 7 01:40:00 2010 -0400 EDT
Sun Nov 7 01:00:00 2010 -0500 EST
Sun Nov 7 01:20:00 2010 -0500 EST
However, neither Local nor Eastern tzinfo instance is capable of reproducing this sequence:
>>> for i in range(-3600, 5000, 1200):
... print(datetime.fromtimestamp(s + i, Eastern).strftime('%c %z %Z'))
Sun Nov 7 00:00:00 2010 -0400 EDT
Sun Nov 7 00:20:00 2010 -0400 EDT
Sun Nov 7 00:40:00 2010 -0400 EDT
Sun Nov 7 01:00:00 2010 -0500 EST
Sun Nov 7 01:20:00 2010 -0500 EST
Sun Nov 7 01:40:00 2010 -0500 EST
Sun Nov 7 01:00:00 2010 -0500 EST
Sun Nov 7 01:20:00 2010 -0500 EST
>>> for i in range(-3600, 5000, 1200):
... print(datetime.fromtimestamp(s + i, Local).strftime('%c %z %Z'))
Sun Nov 7 00:00:00 2010 -0400 EDT
Sun Nov 7 00:20:00 2010 -0400 EDT
Sun Nov 7 00:40:00 2010 -0400 EDT
Sun Nov 7 01:00:00 2010 -0400 EDT
Sun Nov 7 01:20:00 2010 -0400 EDT
Sun Nov 7 01:40:00 2010 -0400 EDT
Sun Nov 7 02:00:00 2010 -0500 EST
Sun Nov 7 02:20:00 2010 -0500 EST
|
|||
| msg109452 - (view) | Author: Alexander Belopolsky (belopolsky) * (Python committer) | Date: 2010年07月07日 04:49 | |
There is nothing we can do about misreporting of UTC offset. Unlike time tuples, datetime objects do not store the DST flag and thus have no means to disambiguate between standard and DST during the hour after the clock is set back for DST to standard transition. Nevertheless, dt = datetime.fromtimestamp(t) is a well defined operation, it is dt.dst() and dt.utcoffset() which are not so well defined. According to the comment at the end of Modules/datetimemodule.c, in order for the default implementation of tzinfo.fromutc() to operate correctly, the concrete implementation of tzinfo.dst(dt) must treat dt that falls into the ambiguous hour (where it can be ether DST or standard time) as the standard time. This is precisely what is done in the implementation of USTimeZone class. The Local class, however, relies on mktime to choose between DST and standard and apparently, at least on OSX, mktime does not do what Python's tzinfo.fromutc() expects. The attached patch for Doc/includes/tzinfo-examples.py fixes this problem by passing is_dst=0 instead of -1 to mktime and also adds __repr__ to LocalTimezone class. With this patch, >>> x = datetime(2010, 11, 7, 5) >>> s = (x - datetime(1970, 1, 1))//timedelta(seconds=1) >>> for i in range(-3600, 5000, 3600): ... datetime.fromtimestamp(s + i, Local) ... datetime.datetime(2010, 11, 7, 0, 0, tzinfo=EST/EDT) datetime.datetime(2010, 11, 7, 1, 0, tzinfo=EST/EDT) datetime.datetime(2010, 11, 7, 1, 0, tzinfo=EST/EDT) which is correct and consistent with Easter timezone: >>> for i in range(-3600, 5000, 3600): ... datetime.fromtimestamp(s + i, Eastern) ... datetime.datetime(2010, 11, 7, 0, 0, tzinfo=Eastern) datetime.datetime(2010, 11, 7, 1, 0, tzinfo=Eastern) datetime.datetime(2010, 11, 7, 1, 0, tzinfo=Eastern) |
|||
| msg124579 - (view) | Author: Alexander Belopolsky (belopolsky) * (Python committer) | Date: 2010年12月24日 00:29 | |
Committed in r87463 (3.2), r87464 (2.7) and r87465 (3.1). |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:02 | admin | set | github: 53309 |
| 2010年12月24日 00:29:37 | belopolsky | set | status: open -> closed versions: + Python 3.1 nosy: mark.dickinson, belopolsky, rbp, docs@python messages: + msg124579 resolution: fixed stage: commit review -> resolved |
| 2010年11月21日 20:34:46 | rbp | set | nosy:
+ rbp |
| 2010年07月07日 04:49:21 | belopolsky | set | files:
+ issue9063.diff type: behavior keywords: + patch nosy: + mark.dickinson messages: + msg109452 stage: needs patch -> commit review |
| 2010年06月23日 18:29:49 | belopolsky | set | messages: + msg108470 |
| 2010年06月23日 17:37:27 | belopolsky | set | messages: + msg108464 |
| 2010年06月23日 17:14:45 | belopolsky | create | |