This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2010年06月07日 18:56 by tjollans, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| aifc_use_str.diff | tjollans, 2010年06月07日 18:55 | patch: aifc: use str | ||
| aifc_str_doc.diff | tjollans, 2010年06月07日 20:53 | library doc patch | ||
| Messages (4) | |||
|---|---|---|---|
| msg107274 - (view) | Author: Thomas Jollans (tjollans) | Date: 2010年06月07日 18:55 | |
aifc getcomptype() and setcomptype() use bytes while the corresponding methods in the sunau and wave modules use str (b'NONE', b'ULAW' vs 'NONE', 'ULAW'). This means that programmers wanting simple format-agnostic audio file output will have to special-case aifc. This was not necessary in Python 2.x, where all three modules used str (obviously). IMHO, there is no reason for this incompatibility. The solution I propose is to change aifc to use unicode str for "information" strings and bytes for raw data only, like the other two modules. This is, the way I see it, the most sensible behaviour. I'm attaching a patch that does just this: it changes aifc to use str for all (non-data) strings: comptype, compname, and markers. I've also changed the testcase accordingly. The problem is, obviously, that this could break existing code. I doubt that it would break a lot of code since: - not that many people use aifc anyway (I think), and py3k is still young - py3k code that's out there now would most likely handle both scenarios anyway to account for the wave and sunau modules - setcomptype() would still accept bytes. On the other hand, it would, as I said, simplify writing format-agnostic code. Special-casing any module wouldn't have been necessary with Python 2, why should Python 3 be any different? There, I've made my case. Georg, I put you on the nosy list because of [svn r64023] Remove cl usage from aifc and use bytes throughout. You, apparently, made the decision I'm arguing should be reverted, if indeed anyone consciously made it at all. If this is applied, it would have to be properly documented, of course. |
|||
| msg107278 - (view) | Author: Thomas Jollans (tjollans) | Date: 2010年06月07日 20:53 | |
tentative documentation patch uploaded |
|||
| msg196869 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) | Date: 2013年09月03日 20:37 | |
I afraid we can't just change comptype to string. We can allow setcomptype() accept strings and convert them to bytes, but we can't change the type of getcomptype()'s result. |
|||
| msg415065 - (view) | Author: Irit Katriel (iritkatriel) * (Python committer) | Date: 2022年03月13日 17:47 | |
aifc is deprecated as per PEP 594, so there won't be further enhancements to it. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:01 | admin | set | github: 53180 |
| 2022年03月13日 17:47:43 | iritkatriel | set | status: open -> closed nosy: + iritkatriel messages: + msg415065 resolution: wont fix stage: resolved |
| 2014年12月19日 00:19:36 | Arfrever | set | nosy:
+ Arfrever |
| 2013年09月03日 20:37:55 | serhiy.storchaka | set | messages: + msg196869 |
| 2013年08月29日 19:54:07 | serhiy.storchaka | set | nosy:
+ r.david.murray |
| 2013年08月29日 19:53:27 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka versions: + Python 3.4, - Python 3.1, Python 3.2 |
| 2010年06月07日 20:53:09 | tjollans | set | files:
+ aifc_str_doc.diff messages: + msg107278 |
| 2010年06月07日 19:48:29 | vstinner | set | nosy:
+ vstinner components: + Unicode |
| 2010年06月07日 18:56:04 | tjollans | create | |