This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2010年04月01日 16:08 by methane, last changed 2022年04月11日 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| fragment.patch | dstanek, 2010年08月03日 22:38 | |||
| Messages (4) | |||
|---|---|---|---|
| msg102103 - (view) | Author: Inada Naoki (methane) * (Python committer) | Date: 2010年04月01日 16:08 | |
>>> urllib2.urlopen("http://wave-robot-python-client.googlecode.com/svn/trunk/pydocs/index.html#module-wavelet")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "C:\usr\Python2.6\lib\urllib2.py", line 126, in urlopen
return _opener.open(url, data, timeout)
File "C:\usr\Python2.6\lib\urllib2.py", line 398, in open
response = meth(req, response)
File "C:\usr\Python2.6\lib\urllib2.py", line 511, in http_response
'http', request, response, code, msg, hdrs)
File "C:\usr\Python2.6\lib\urllib2.py", line 436, in error
return self._call_chain(*args)
File "C:\usr\Python2.6\lib\urllib2.py", line 370, in _call_chain
result = func(*args)
File "C:\usr\Python2.6\lib\urllib2.py", line 519, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 400: Bad Request
This happens when redirected URL contains fragment.
>>> urllib2.urlopen("http://goo.gl/z1d5")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "C:\usr\Python2.6\lib\urllib2.py", line 126, in urlopen
return _opener.open(url, data, timeout)
File "C:\usr\Python2.6\lib\urllib2.py", line 398, in open
response = meth(req, response)
File "C:\usr\Python2.6\lib\urllib2.py", line 511, in http_response
'http', request, response, code, msg, hdrs)
File "C:\usr\Python2.6\lib\urllib2.py", line 430, in error
result = self._call_chain(*args)
File "C:\usr\Python2.6\lib\urllib2.py", line 370, in _call_chain
result = func(*args)
File "C:\usr\Python2.6\lib\urllib2.py", line 606, in http_error_302
return self.parent.open(new, timeout=req.timeout)
File "C:\usr\Python2.6\lib\urllib2.py", line 398, in open
response = meth(req, response)
File "C:\usr\Python2.6\lib\urllib2.py", line 511, in http_response
'http', request, response, code, msg, hdrs)
File "C:\usr\Python2.6\lib\urllib2.py", line 436, in error
return self._call_chain(*args)
File "C:\usr\Python2.6\lib\urllib2.py", line 370, in _call_chain
result = func(*args)
File "C:\usr\Python2.6\lib\urllib2.py", line 519, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 400: Bad Request
urllib2.Request.get_selector() should be:
def get_selector(self):
return self.__r_host.split('#')[0]
|
|||
| msg112712 - (view) | Author: David Stanek (dstanek) | Date: 2010年08月03日 22:38 | |
Added a patch to fix this behavior. |
|||
| msg112721 - (view) | Author: David Stanek (dstanek) | Date: 2010年08月03日 23:19 | |
I have also uploaded my patch to http://codereview.appspot.com/1918042 so easier viewing. |
|||
| msg113250 - (view) | Author: Senthil Kumaran (orsenthil) * (Python committer) | Date: 2010年08月08日 11:47 | |
Fixed in revision 83818(py3k), 83819 (release31-maint) and 83820 (release27-maint). David, a couple of comments on your patch. - Request method was from urllib2, so the proper place of tests were test_urllib2. This already had Requests test so some additional tests were only required. - Also, now the fragments are removed and sent to the server, a proper response could be obtained, it can tested via 'network' tests in test_urllib2net. You might check the svn diffs to see the changes made. Thanks for the patch. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:56:59 | admin | set | github: 52527 |
| 2010年08月08日 11:47:46 | orsenthil | set | status: open -> closed resolution: accepted -> fixed stage: resolved |
| 2010年08月08日 11:47:21 | orsenthil | set | messages: + msg113250 |
| 2010年08月03日 23:19:44 | dstanek | set | messages: + msg112721 |
| 2010年08月03日 22:38:18 | dstanek | set | files:
+ fragment.patch nosy: + dstanek messages: + msg112712 keywords: + patch |
| 2010年04月06日 05:08:14 | orsenthil | set | assignee: orsenthil resolution: accepted |
| 2010年04月01日 16:16:10 | eric.araujo | set | nosy:
+ eric.araujo |
| 2010年04月01日 16:12:31 | brian.curtin | set | nosy:
+ orsenthil versions: - Python 2.5, Python 3.3 |
| 2010年04月01日 16:09:24 | methane | set | type: behavior components: + Library (Lib) versions: + Python 2.6, Python 2.5, Python 3.1, Python 2.7, Python 3.2, Python 3.3 |
| 2010年04月01日 16:08:31 | methane | create | |