homepage

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: errno and strerror attributes incorrectly set on socket errors wrapped by urllib
Type: behavior Stage: needs patch
Components: Library (Lib) Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: amaury.forgeotdarc, catherine, chris.jerdonek, denkoren, ezio.melotti, georg.brandl, iritkatriel, orsenthil, r.david.murray
Priority: normal Keywords: patch

Created on 2009年07月12日 20:54 by ezio.melotti, last changed 2022年04月11日 14:56 by admin.

Files
File name Uploaded Description Edit
keeperrdata.patch catherine, 2012年07月29日 02:52 patch to retain errno and strerror review
Messages (9)
msg90458 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2009年07月12日 20:54
In Python 2.6, socket.error was changed to be a child class of IOError
[1]. IOError derives from EnvironmentError [2], and EnvironmentError
accepts a 2-tuple used to set the values of the errno and strerror
attributes respectively [3].
Apparently the IOError raised by the socket module are instantiated
passing (always?) 'socket error' as first arg and an instance of
socket.gaierror, socket.timeout or socket.herror (and maybe others) as
second arg.
The errno attributes ends up being a string (and not a number) and the
strerror another exception (and not a str):
>>> import socket
>>> from urllib import urlopen
>>> socket.setdefaulttimeout(0.01)
>>> try: urlopen('http://www.python.org')
... except Exception, e: err1 = e
...
>>> err1
IOError('socket error', timeout('timed out',))
>>> err1.errno
'socket error'
>>> err1.strerror
timeout('timed out',)
>>> err1.strerror.errno
>>> err1.strerror.strerror
>>>
>>> try: urlopen('http://www.pythonfoobarbaz.org')
... except Exception, e: err2 = e
...
>>> err2
IOError('socket error', gaierror(11001, 'getaddrinfo failed'))
>>> err1.errno
'socket error'
>>> err1.strerror
timeout('timed out',)
>>> err1.strerror.errno
>>> err2.errno
'socket error'
>>> err2.strerror
gaierror(11001, 'getaddrinfo failed')
>>> err2.strerror.errno
11001
>>> err2.strerror.strerror
'getaddrinfo failed'
The 'socket error' strings doesn't provide any useful information
(herror, gaierror and timeout are already subclasses of socket.error)
and it results in confusing messages like:
IOError: [Errno socket error] [Errno 11001] getaddrinfo failed
The relevant information is not accessible directly on the error but it
is in err.strerror/err.args[1].
IMHO the first arg should be the errno (if it's available) and the
second the message (e.g. 'getaddrinfo failed' or 'timed out').
The doc of socket.error [1] should be also changed because it says:
"The accompanying value is either a string telling what went wrong or a
pair (errno, string) representing an error returned by a system call,
similar to the value accompanying os.error." (and this is actually what
I'd like it to be, but right now it's something different.)
[1]: http://docs.python.org/library/socket.html#socket.error
[2]: http://docs.python.org/library/exceptions.html#exceptions.IOError
[3]:
http://docs.python.org/library/exceptions.html#exceptions.EnvironmentError 
msg90462 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2009年07月12日 23:15
No, it seems that 2.5 has the same problem. The 'socket error' message is 
raised in urllib.py. The socket module is innocent to me...
It appears that this file routinely raises IOErrors, passing various 
arguments, which are not stored properly in the IOError object. IMO it 
should raise subclasses of IOError.
In this particular case of "socket error", it should let the exception 
propagate. Other occurrences need more thinking.
msg90466 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2009年07月13日 02:36
Yes, it looks to me like urllib is intentionally putting the 'socket
error' or 'url error' into the errno position in the IOError arguments.
 Now that socket.error is an IOError, that at least seems wrong.
msg100178 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2010年02月27日 09:24
Can this be fixed without breaking compatibility?
It also affects Python2.7 and maybe also Python 3.x (there the error is different and might be intentional).
Copy/pastable snippet to reproduce the error on 2.x:
from urllib import urlopen
try:
 urlopen('http://www.pythonfoobarbaz.org')
except Exception, err:
 print 'err:', err
 print 'repr(err):', repr(err)
 print 'err.errno:', err.errno
 print 'err.strerror:', err.strerror
 print 'err.strerror.errno:', err.strerror.errno
 print 'err.strerror.strerror:', err.strerror.strerror
Result on 2.7:
err: [Errno socket error] [Errno -2] Name or service not known
repr(err): IOError('socket error', gaierror(-2, 'Name or service not known'))
err.errno: socket error
err.strerror: [Errno -2] Name or service not known
err.strerror.errno: -2
err.strerror.strerror: Name or service not known
Copy/pastable snippet to reproduce the error on 3.x:
from urllib.request import urlopen
try:
 urlopen('http://www.pythonfoobarbaz.org')
except Exception as exc:
 err = exc
 print('err:', err)
 print('repr(err):', repr(err))
 print('err.errno:', err.errno)
 print('err.strerror:', err.strerror)
 print('err.reason:', err.reason)
 print('err.reason.errno:', err.reason.errno)
 print('err.reason.strerror:', err.reason.strerror)
Result on 3.2:
err: <urlopen error [Errno -2] Name or service not known>
repr(err): URLError(gaierror(-2, 'Name or service not known'),)
err.errno: None
err.strerror: None
err.reason: [Errno -2] Name or service not known
err.reason.errno: -2
err.reason.strerror: Name or service not known
msg166705 - (view) Author: Catherine Devlin (catherine) Date: 2012年07月29日 02:52
It's very hard to tell what ought to be done here, since Lib/urllib/request.py throws URLErrors with a great variety of order and number of arguments, and it's not clear how URLError (in Lib/urllib/error.py) intends to handle them.
However, in this case, AbstractHTTPHandler.do_open is instantiating URLError with another exception instance, and that exception contains .errno and .strerror. URLError puts the entire error instance into ``reason``, where the information is hidden away as .reason.strno and .reason.strerror. 
In the name of keeping this information available rather than hiding it, I'm attaching a patch that adds to URLError.__init__:
 if hasattr(reason, "errno"):
 self.errno = reason.errno
 if hasattr(reason, "strerror"):
 self.strerror = reason.strerror
Again, I'm not sure this is the most logical approach because I can't find a consistent pattern in the ways URLError is instantiated.
msg167330 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2012年08月03日 14:10
This is an interesting idea and should at least improve matters. I'm wondering, though...I seem to remember writing code that fished the wrapped error out using one of those attributrs...but I'm not at a computer where I can try to check on that. Hopefully I can check on it this weekend.
msg170710 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2012年09月19日 07:51
> I seem to remember writing code that fished the wrapped error
> out using one of those attributrs...
That would be err.reason:
from urllib.request import urlopen
try:
 urlopen('http://www.pythonfoobarbaz.org')
except Exception as exc:
 print('err:', err)
 print('repr(err):', repr(err))
 print('err.reason:', err.reason)
 print('repr(err.reason):', repr(err.reason))
prints:
err: <urlopen error [Errno -2] Name or service not known>
repr(err): URLError(gaierror(-2, 'Name or service not known'),)
err.reason: [Errno -2] Name or service not known
repr(err.reason): gaierror(-2, 'Name or service not known')
msg170723 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2012年09月19日 13:56
Ah, of course. I should have reread the whole issue :)
The backward compatibility is the big concern here. Regardless of what we do about that, we should at least fix this in 3.4.
msg407399 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2021年11月30日 20:20
Reproduced on 3.11:
>>> from urllib.request import urlopen
>>> try:
... urlopen('http://www.pythonfoobarbaz.org')
... except Exception as exc:
... err = exc
... print('err:', err)
... print('repr(err):', repr(err))
... print('err.errno:', err.errno)
... print('err.strerror:', err.strerror)
... print('err.reason:', err.reason)
... print('err.reason.errno:', err.reason.errno)
... print('err.reason.strerror:', err.reason.strerror)
... 
err: <urlopen error [Errno 8] nodename nor servname provided, or not known>
repr(err): URLError(gaierror(8, 'nodename nor servname provided, or not known'))
err.errno: None
err.strerror: None
err.reason: [Errno 8] nodename nor servname provided, or not known
err.reason.errno: 8
err.reason.strerror: nodename nor servname provided, or not known
History
Date User Action Args
2022年04月11日 14:56:50adminsetgithub: 50720
2021年11月30日 20:20:38iritkatrielsetnosy: + iritkatriel

messages: + msg407399
versions: + Python 3.9, Python 3.10, Python 3.11, - Python 2.6, Python 3.1, Python 2.7, Python 3.2
2013年07月29日 17:16:59r.david.murraysetnosy: + denkoren
2013年07月29日 17:16:38r.david.murraylinkissue18587 superseder
2012年09月19日 13:56:39r.david.murraysetmessages: + msg170723
2012年09月19日 07:51:48chris.jerdoneksetnosy: + chris.jerdonek
2012年09月19日 07:51:05ezio.melottisetmessages: + msg170710
2012年08月03日 14:10:56r.david.murraysetmessages: + msg167330
2012年07月29日 02:52:55catherinesetfiles: + keeperrdata.patch

nosy: + catherine
messages: + msg166705

keywords: + patch
2010年02月27日 09:25:00ezio.melottisetversions: + Python 3.1, Python 2.7, Python 3.2
nosy: + orsenthil

messages: + msg100178

stage: needs patch
2009年07月13日 02:37:48r.david.murraysettitle: errno and strerror attributes incorrectly set on socket.error -> errno and strerror attributes incorrectly set on socket errors wrapped by urllib
2009年07月13日 02:37:00r.david.murraysetnosy: + r.david.murray
messages: + msg90466
2009年07月12日 23:15:16amaury.forgeotdarcsetnosy: + amaury.forgeotdarc
messages: + msg90462

assignee: georg.brandl ->
components: - Documentation
2009年07月12日 20:54:34ezio.melotticreate

AltStyle によって変換されたページ (->オリジナル) /