Issue591713
Created on 2002年08月06日 19:26 by callenish, last changed 2022年04月10日 16:05 by admin. This issue is now closed.
| Files |
|---|
| File name |
Uploaded |
Description |
Edit |
|
urlparse.patch
|
callenish,
2002年08月06日 19:26
|
| Messages (4) |
|---|
|
msg40855 - (view) |
Author: Bruce Atherton (callenish) |
Date: 2002年08月06日 19:26 |
If you run urlparse.urljoin() on a file: URL, the resulting URL
has together with the wrong number of '/'s in it.
Properly formed, the URL (assuming no netloc) should have
three slashes, so that it looks like "file:///...". The current
code drops that down to one.
The error appears to be in a condition in urlunsplit(). It
doesn't show up except in this one instance because the
test is only run iff the scheme is in the list of those that can
take a netloc and there is no netloc present in the URL.
Apparently, this is pretty rare.
Patch attached that corrects the condition.
|
|
msg40856 - (view) |
Author: Neal Norwitz (nnorwitz) * (Python committer) |
Date: 2002年09月17日 21:22 |
Logged In: YES
user_id=33168
Not sure who is best to review this? Fred? Jeremy?
Someone else?
This patch works for me. I have a test too. Assign back to
me if you want me to check it in.
|
|
msg40857 - (view) |
Author: Fred Drake (fdrake) (Python committer) |
Date: 2002年09月25日 14:46 |
Logged In: YES
user_id=3066
Looks good to me; go ahead and check it in with the tests.
Thanks!
|
|
msg40858 - (view) |
Author: Neal Norwitz (nnorwitz) * (Python committer) |
Date: 2002年09月25日 19:22 |
Logged In: YES
user_id=33168
Checked in as:
* urlparse.py 1.33 and 1.31.6.2
* test_urlparse.py 1.7 and 1.2.24.2
* output/test_urlparse 1.2.24.2
|
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2022年04月10日 16:05:33 | admin | set | github: 36991 |
| 2002年08月06日 19:26:03 | callenish | create |