homepage

Last week I noticed that the pickle and cPickle modules
cannot handle bound methods. I found a solution that is
simple and (I think) general, so perhaps it should
become part of the standard library.
Here is my code:
import copy_reg
def pickle_bound_method(method):
 return getattr, (method.im_self, method.__name__)
class _Foo:
 def bar(self):
 pass
_foo = _Foo()
copy_reg.constructor(getattr)
copy_reg.pickle(type(_foo.bar), pickle_bound_method)

Logged In: YES 
user_id=21627
Making getattr a safe_constructor has security implictions
which make this approach dangerous. It seems that unpickling
might invoke arbitrary __getattr__ implementations. Adding a
protocol to declare classes as "safe for getattr" might help.

Logged In: YES 
user_id=21627
Can you perhaps rewrite this to use new.instancemethod?

Logged In: YES 
user_id=11850
Of course:
import copy_reg
def get_method(object, name):
 klass = object.__class__
 fn = klass.__dict__[name]
 return new.instancemethod(fn, object, klass)
def pickle_bound_method(method):
 return get_method, (method.im_self, method.__name__)
class _Foo:
 def bar(self):
 pass
_foo = _Foo()
copy_reg.constructor(get_method)
copy_reg.pickle(type(_foo.bar), pickle_bound_method)

Logged In: YES 
user_id=21627
That sounds good to me; I'm going to install it.

Logged In: YES 
user_id=21627
Reconsidering: It fails to work in the presence of
inheritance, right?
>>> class B:
... def foo(self):pass
... 
>>> class D(B):pass
... 
>>> d = D()
>>> m = d.foo
>>> m.im_self
<__main__.D instance at 0x1ccb28>
>>> m.__name__
'foo'
>>> D.__dict__['foo']
Traceback (most recent call last):
 File "<stdin>", line 1, in ?
KeyError: foo
>>> 

Logged In: YES 
user_id=11850
True. Would it be a security problem to use getattr inside a 
specialized constructor? For example,
def get_method(object, name):
 klass = object.__class__
 fn = getattr(klass, name)
 return new.instancemethod(fn, object, klass)
This would be difficult to abuse as a general getattr 
replacement, because new.instancemethod would fail in most 
cases other than the intended one.

Logged In: YES 
user_id=21627
My concern is that the getattr call already creates a
danger, since you just have to find a 'suitable' object
whose __getattr__ does funny things. In the revised form,
this object would also have to appear as the __class__ of
some other object, so I guess this is pretty safe. I'll ask
python-dev.

Logged In: YES 
user_id=80475
Any progress on this one?

Logged In: YES 
user_id=21627
There was some discussion on python-dev (initiated by
Christian) on whether bound methods should provide an
__reduce__. Apart from that, no progress.

Personally, I don't see how adding this feature would create a security
hole (or more properly said, grow the giant hole that are the GLOBAL and
 REDUCE opcodes). I don't see either why this should be included in the
standard library.
Unless there is still a need for this feature, I think this bug should
be closed.

I am leaving this issue open for now.
I reconsidered whether we should add pickle support for methods and I
now think it would probably be a good idea. For example, the
multiprocessing module would benefit from a having built-in support for
method pickling (right now, it has to subclass Pickler to pickle methods).

See also issue3657. For some reasons, C bound methods aliased as module globals can be pickled, but not similarly aliased Python bound methods:
>>> random.random, random.seed
(<built-in method random of Random object at 0x27abe20>, <bound method Random.seed of <random.Random object at 0x27abe20>>)
>>> pickle.dumps(random.random)
b'\x80\x03crandom\nrandom\nq\x00.'
>>> pickle.dumps(random.seed)
Traceback (most recent call last):
 File "<stdin>", line 1, in <module>
 File "/home/antoine/py3k/__svn__/Lib/pickle.py", line 1314, in dumps
 Pickler(f, protocol, fix_imports=fix_imports).dump(obj)
_pickle.PicklingError: Can't pickle <class 'method'>: attribute lookup builtins.method failed

Let's continue the discussion on issue9276.