homepage

The test case below will (on Linux here) eventually quit with "OSError:
[Errno 24] Too many open files". I assume that some additional cleaning
up is in order.
-------------------------------------------------------------------
from subprocess import Popen, PIPE
while 1:
 try:
 Popen(['nonexisting'], stdout=PIPE, stderr=PIPE)
 except OSError, err:
 if err.errno != 2: # ignore "no such file"
 raise

Proposed patch attached.

Perhaps you could add a test?

I would, but how this fails is likely to be highly platform-specific. 
Can you try it on Windows and tell me what the resulting exception is?

Well, I'm not under Windows. I'll try to launch a VM if nobody beats me
to it...

On second thought, if the patch is applied, there *shouldn't* be an
exception. And simply running the loop for a fixed number of
repetitions isn't a good test either, since different platforms may have
a different maximum for open file descriptors.
Hmm, is there a way to get the current number of open file descriptors?

> Hmm, is there a way to get the current number of open file descriptors?
Under Unix, you can use resource.getrlimit():
(1024, 1024)
But 1024 is a very common value, so you could simply loop 1024 times if
it's not too slow.
Besides, you definitely don't want to loop 2**31 times if 2**31 happens
to be the current limit.

Wow, the Roundup email gateway borks code snippets:
>>> import resource
>>> resource.getrlimit(resource.RLIMIT_NOFILE)
(1024, 1024)

OK, Windows has 2048. Added test and fixed in r69620.

This issue is not fixed on windows yet. (test_leaking_fds_on_error fails)
I think attached patch will fix this.
======================================================================
ERROR: test_writes_before_communicate (__main__.ProcessTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
 File "test_subprocess.py", line 398, in test_writes_before_communicate
 File "e:\python-dev\py3k\lib\subprocess.py", line 632, in __init__
 File "e:\python-dev\py3k\lib\subprocess.py", line 746, in _get_handles
IOError: [Errno 24] Too many open files

Since I can't test on Windows, I'll leave that in your hands :)

Thanks, fixed in r70137(trunk), r70142(py3k), r70146(release30-maint),
r70147(release26-maint)