This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2009年01月18日 21:02 by benjamin.peterson, last changed 2022年04月11日 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| raise_on_bad_fd.patch | benjamin.peterson, 2009年01月18日 21:54 | |||
| raise_on_bad_fd2.patch | benjamin.peterson, 2009年01月18日 23:52 | |||
| Messages (8) | |||
|---|---|---|---|
| msg80125 - (view) | Author: Benjamin Peterson (benjamin.peterson) * (Python committer) | Date: 2009年01月18日 21:02 | |
Since os.fdopen is now implemented with io.open, it doesn't use fdopen and check for invalid file descriptors. This isn't a huge issue since subsequent actions on the file will raise an error. |
|||
| msg80128 - (view) | Author: Antoine Pitrou (pitrou) * (Python committer) | Date: 2009年01月18日 21:23 | |
Perhaps io.open should be fixed, then? (or the _FileIO constructor) |
|||
| msg80130 - (view) | Author: Benjamin Peterson (benjamin.peterson) * (Python committer) | Date: 2009年01月18日 21:54 | |
Here's a patch for _FileIO. |
|||
| msg80135 - (view) | Author: Antoine Pitrou (pitrou) * (Python committer) | Date: 2009年01月18日 23:21 | |
I think EBADF is defined everywhere, so you can drop the defined() conditional. |
|||
| msg80136 - (view) | Author: Benjamin Peterson (benjamin.peterson) * (Python committer) | Date: 2009年01月18日 23:52 | |
Attaching new patch... |
|||
| msg80137 - (view) | Author: Antoine Pitrou (pitrou) * (Python committer) | Date: 2009年01月19日 00:03 | |
I'm not sure Windows has a valid fstat btw, I'll guess we'll see on the Windows buildbots (in that case, some code can be taken from posixmodule.c to emulate fstat behaviour...). Other than that, the patch looks fine to me. |
|||
| msg80138 - (view) | Author: Benjamin Peterson (benjamin.peterson) * (Python committer) | Date: 2009年01月19日 00:09 | |
Applied in r68755. Will watch Windows. |
|||
| msg80176 - (view) | Author: Benjamin Peterson (benjamin.peterson) * (Python committer) | Date: 2009年01月19日 15:14 | |
Well, the Windows bot is failing but not from test_fileio, so I'll go ahead and merge it. r68767. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:56:44 | admin | set | github: 49241 |
| 2009年01月19日 15:14:38 | benjamin.peterson | set | messages: + msg80176 |
| 2009年01月19日 00:09:38 | benjamin.peterson | set | status: open -> closed resolution: fixed messages: + msg80138 |
| 2009年01月19日 00:03:53 | pitrou | set | messages: + msg80137 |
| 2009年01月18日 23:52:22 | benjamin.peterson | set | files:
+ raise_on_bad_fd2.patch messages: + msg80136 |
| 2009年01月18日 23:21:51 | pitrou | set | messages: + msg80135 |
| 2009年01月18日 21:54:49 | benjamin.peterson | set | files:
+ raise_on_bad_fd.patch keywords: + patch messages: + msg80130 |
| 2009年01月18日 21:23:42 | pitrou | set | nosy:
+ pitrou messages: + msg80128 |
| 2009年01月18日 21:02:02 | benjamin.peterson | create | |