homepage

abstract.c defines two functions _add_one_to_C and _add_one_to_F. These
apparently must be global, as memoryobject.c references them. Therefore,
they should get a Py or _Py prefix.
A short comment for what these functions actually do would also be
appreciated.

This seems to be fixed in r62348
http://svn.python.org/view?rev=62348&view=rev 

Ok, so it's fixed for the trunk, but not Py3k. The trunk fix doesn't
port to 3k, since the functions are called inside memoryobject.c (so
making them static would break that module).

A sensible solution would be to put all the memoryview / buffer API
stuff in the same standalone file (e.g. memoryobject.c), rather than
having half of it dumped in abstract.c.

I've added comments in the code to document these functions. I have no
opinion where they live except they should probably be available to
extensions modules. 
These routines increment an N-length counter representing a position in
an N-dimensional array with wrap-around when the counter reaches the
size of the dimension. Thus, for a (2,3) array we have:
F-version
0,0
1,0
2,0
0,1
1,1
2,1
C-version
0,0
0,1
0,2
1,0
1,1
1,2

I think _add_one_to_index_C and _add_one_to_index_F should be renamed.
If they are meant to be called by non-core extension modules, their
names should start with Py_, else with _Py_.

I think they currently are private functions which happen to be used
accross two different C source files. So they should be renamed
_Py_something (or the situation should be fixed so that they can be made
static).

> I think they currently are private functions which happen to be used
> accross two different C source files. 
But see msg71879 

Well, then a proper API should be devised. Perhaps Travis can shed more
light on what he thinks would be useful.

Functions are still present and non-static in trunk.

I've added a "_Py" prefix in r84391, and also made the `shape` argument const. If numpy people want this to be an official public API, they'll have to contribute. Thanks.