homepage

When Parser/asdl_c.py is composing the content of Python/Python-ast.c, it uses "value" to name the variables in inner blocks, which can shadow the variables named the same in outer blocks. It would be a good practice to avoid the shadowing naming to prevent the variables from being misused.

What actually omits warnings about this?

This can be repro by setting -Wshadow-compatible-local when using gcc to compile Python-ast.c.
An example on my machine:
➜ cpython git:(69c0db5050) ✗ gcc-7 -Wshadow-compatible-local -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I./Include -I. -I/usr/local/opt/readline/include -I/usr/local/opt/openssl/include -I/Users/python/.pyenv/versions/3.6.1/include -I/usr/local/include -I/Users/python/.pyenv/versions/3.6.1/include/python3.6m -c Python/Python-ast.c -o build/temp.macosx-10.12-x86_64-3.6/Python-ast.o
Python/Python-ast.c: In function 'obj2ast_stmt':
Python/Python-ast.c:4586:25: warning: declaration of 'value' shadows a previous local [-Wshadow=compatible-local]
 expr_ty value;
 ^~~~~
Python/Python-ast.c:4570:17: note: shadowed declaration is here
 expr_ty value;
 ^~~~~

The actual change is just three lines in asdl_c.py. Python-ast.c is generated.

Thanks!