This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2017年02月17日 22:10 by prayerslayer, last changed 2022年04月11日 14:58 by admin.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 143 | closed | prayerslayer, 2017年02月17日 22:10 | |
| PR 23864 | closed | python-dev, 2020年12月20日 02:27 | |
| PR 23865 | closed | tianc777, 2020年12月20日 02:40 | |
| Messages (6) | |||
|---|---|---|---|
| msg288043 - (view) | Author: prayerslayer (prayerslayer) * | Date: 2017年02月17日 22:10 | |
Hi! I think the ThreadPoolExecutor should allow to set the maximum size of the underlying queue. The situation I ran into recently was that I used ThreadPoolExecutor to parallelize AWS API calls; I had to move data from one S3 bucket to another (~150M objects). Contrary to what I expected the maximum size of the underlying queue doesn't have a non-zero value by default. Thus my process ended up consuming gigabytes of memory, because it put more items into the queue than the threads were able to work off: The queue just kept growing. (It ran on K8s and the pod was rightfully killed eventually.) Of course there ways to work around this. One could use more threads, to some extent. Or you could use your own queue with a defined maximum size. But I think it's more work for users of Python than necessary. |
|||
| msg289082 - (view) | Author: prayerslayer (prayerslayer) * | Date: 2017年03月06日 09:33 | |
Hello again, there's a reviewed PR open for this issue and it hasn't even received authoritative feedback yet (ie whether or not you intend to support this feature at all). I would be very happy if a core dev could look over this change before everyone forgets about it :) |
|||
| msg290253 - (view) | Author: prayerslayer (prayerslayer) * | Date: 2017年03月24日 22:38 | |
Ping. That's really a two-line change, can be easily reviewed in 15 minutes :) |
|||
| msg290949 - (view) | Author: Raymond Hettinger (rhettinger) * (Python committer) | Date: 2017年03月31日 23:19 | |
Prayslayer, please don't shove. Your PR request was responded to by Mariatta so it wasn't ignored. Making decisions about API expansions takes a while (making sure it fits the intended use, that it isn't a bug factory itself, that it is broadly useful, that it is the best solution to the problem, that is doesn't complicate the implementation or limit future opportunities, that there are unforeseen problems). Among the core developers, there are only a couple part-time contributors who are qualified to make these assessments for the multi-processing module (those devs don't include me). |
|||
| msg314699 - (view) | Author: Stephen ONeal (stephen.oneal.04) | Date: 2018年03月30日 17:27 | |
My project we're going into the underlying _work_queue and blocking adding more elements based on unfinished_tasks to accomplish this, bubbling this up to the API would be a welcome addition. |
|||
| msg314743 - (view) | Author: Antoine Pitrou (pitrou) * (Python committer) | Date: 2018年03月31日 17:06 | |
Please note the PR here has some review comments that need addressing. Also, it needs its conflicts with git master resolved. I'm cc'ing Thomas Moreau, who has done a lot of work recently on the concurrent.futures internals. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:58:43 | admin | set | github: 73781 |
| 2021年10月14日 21:59:47 | iforapsy | set | nosy:
+ iforapsy |
| 2020年12月20日 02:40:45 | tianc777 | set | nosy:
+ tianc777 pull_requests: + pull_request22727 |
| 2020年12月20日 02:27:10 | python-dev | set | keywords:
+ patch nosy: + python-dev pull_requests: + pull_request22726 |
| 2018年03月31日 17:06:25 | pitrou | set | versions:
+ Python 3.8, - Python 3.7 nosy: + tomMoral messages: + msg314743 assignee: davin -> |
| 2018年03月31日 17:04:32 | pitrou | link | issue14119 superseder |
| 2018年03月30日 17:27:23 | stephen.oneal.04 | set | nosy:
+ stephen.oneal.04 messages: + msg314699 |
| 2017年03月31日 23:19:49 | rhettinger | set | assignee: davin messages: + msg290949 nosy: + pitrou, davin, rhettinger |
| 2017年03月31日 22:01:46 | Mariatta | set | stage: patch review |
| 2017年03月24日 22:38:56 | prayerslayer | set | messages: + msg290253 |
| 2017年03月06日 09:33:15 | prayerslayer | set | messages: + msg289082 |
| 2017年02月20日 09:19:59 | xiang.zhang | set | nosy:
+ xiang.zhang |
| 2017年02月18日 23:12:56 | Jim Fasarakis-Hilliard | set | nosy:
+ Jim Fasarakis-Hilliard |
| 2017年02月18日 12:32:00 | Mariatta | set | components:
+ Library (Lib) versions: + Python 3.7 |
| 2017年02月17日 22:10:23 | prayerslayer | create | |