This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2008年05月16日 04:37 by brett.cannon, last changed 2022年04月11日 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| remove_commands.patch | quentin.gallet-gilles, 2008年05月23日 12:29 | Remove commands in py3k | ||
| commands_2.6.patch | quentin.gallet-gilles, 2008年05月23日 12:30 | Document the removal in trunk | ||
| commands_import_fixer.patch | quentin.gallet-gilles, 2008年05月26日 21:15 | |||
| Messages (10) | |||
|---|---|---|---|
| msg66894 - (view) | Author: Brett Cannon (brett.cannon) * (Python committer) | Date: 2008年05月16日 04:37 | |
The commands module is slated to go. The getstatus() function needs to be deprecated, with the rest of the module moving into subprocess (and thus adding commands to the 2to3 fix_import fixer). |
|||
| msg67154 - (view) | Author: Quentin Gallet-Gilles (quentin.gallet-gilles) | Date: 2008年05月21日 13:59 | |
I'm working on it. |
|||
| msg67229 - (view) | Author: Quentin Gallet-Gilles (quentin.gallet-gilles) | Date: 2008年05月23日 12:25 | |
Ok, here are the patches. Since it's a combination of renaming and removing, I had to improvize a little, particularly in the 2.6 documentation. Hope it's done correctly. I still have doubts about the following issue, as commented in test_commands.py : # The module says: # "NB This only works (and is only relevant) for UNIX." # # Actually, getoutput should work on any platform with an os.popen, but # I'll take the comment as given, and skip this suite. I played it safe as well and didn't change the platform test (both in trunk/test_py3kwarn and py3k/test_subprocess). Should this restriction remain ? |
|||
| msg67230 - (view) | Author: Quentin Gallet-Gilles (quentin.gallet-gilles) | Date: 2008年05月23日 12:29 | |
Ok, here are the patches. Since it's a combination of renaming and removing, I had to improvise a little (particularly in the 2.6 documentation). Hope it's done correctly. I still have doubts about the following issue. As commented in test_commands.py: # The module says: # "NB This only works (and is only relevant) for UNIX." # # Actually, getoutput should work on any platform with an os.popen, but # I'll take the comment as given, and skip this suite. I also decided to play it safe and didn't change the test (both in trunk/test_py3kwarn and py3k/test_subprocess). Should this restriction remain? |
|||
| msg67231 - (view) | Author: Quentin Gallet-Gilles (quentin.gallet-gilles) | Date: 2008年05月23日 12:30 | |
Sorry for the double post |
|||
| msg67382 - (view) | Author: Brett Cannon (brett.cannon) * (Python committer) | Date: 2008年05月26日 19:05 | |
r63715 has the 3.0 changes; biggest difference is that I also ripped out the mk2arg() and friends since they are not used by anyone. I still need to add the fixer and add the proper warnings in 2.6 along with the doc change. |
|||
| msg67384 - (view) | Author: Benjamin Peterson (benjamin.peterson) * (Python committer) | Date: 2008年05月26日 19:44 | |
2.6 things done in r63721. |
|||
| msg67389 - (view) | Author: Brett Cannon (brett.cannon) * (Python committer) | Date: 2008年05月26日 20:06 | |
Thanks for adding the warnings, Benjamin. The docs for 2.6 still need to be updated about the rename/merge. I have replied to your commit with some comments. And I think the 2to3 fixer still needs to be done. Because of all this I am re-opening this issue. |
|||
| msg67395 - (view) | Author: Quentin Gallet-Gilles (quentin.gallet-gilles) | Date: 2008年05月26日 21:15 | |
I've updated the 2to3 import fixer (mkarg/mk2arg not handled anymore). |
|||
| msg67397 - (view) | Author: Benjamin Peterson (benjamin.peterson) * (Python committer) | Date: 2008年05月26日 21:31 | |
I've committed Quentin's 2to3 addition as r63729. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:56:34 | admin | set | nosy:
+ barry github: 47121 |
| 2008年05月26日 21:31:36 | benjamin.peterson | set | status: open -> closed resolution: fixed messages: + msg67397 |
| 2008年05月26日 21:15:34 | quentin.gallet-gilles | set | files:
+ commands_import_fixer.patch messages: + msg67395 |
| 2008年05月26日 21:14:48 | quentin.gallet-gilles | set | files: - commands_import_fixer.patch |
| 2008年05月26日 20:06:59 | brett.cannon | set | status: closed -> open resolution: fixed -> (no value) messages: + msg67389 |
| 2008年05月26日 19:51:33 | benjamin.peterson | unlink | issue2775 dependencies |
| 2008年05月26日 19:44:13 | benjamin.peterson | set | status: open -> closed resolution: fixed messages: + msg67384 nosy: + benjamin.peterson |
| 2008年05月26日 19:05:28 | brett.cannon | set | messages: + msg67382 |
| 2008年05月26日 01:30:57 | brett.cannon | set | assignee: brett.cannon |
| 2008年05月23日 12:31:27 | quentin.gallet-gilles | set | files: + commands_import_fixer.patch |
| 2008年05月23日 12:31:00 | quentin.gallet-gilles | set | files:
+ commands_2.6.patch messages: + msg67231 |
| 2008年05月23日 12:29:51 | quentin.gallet-gilles | set | files: - remove_commands.patch |
| 2008年05月23日 12:29:31 | quentin.gallet-gilles | set | files:
+ remove_commands.patch messages: + msg67230 |
| 2008年05月23日 12:26:07 | quentin.gallet-gilles | set | files:
+ remove_commands.patch keywords: + patch messages: + msg67229 |
| 2008年05月21日 13:59:13 | quentin.gallet-gilles | set | nosy:
+ quentin.gallet-gilles messages: + msg67154 |
| 2008年05月16日 04:37:44 | brett.cannon | link | issue2775 dependencies |
| 2008年05月16日 04:37:26 | brett.cannon | create | |