This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2008年05月12日 18:00 by gpolo, last changed 2022年04月11日 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| tkinter_package.py | gpolo, 2008年05月12日 20:44 | creates tkinter package with renamed lib-tk files | ||
| tkinter_imports.diff | gpolo, 2008年05月12日 20:44 | fix imports inside new tkinter package | ||
| tkinter_step2.diff | gpolo, 2008年05月16日 15:44 | |||
| tkinter_doc_updates.diff | gpolo, 2008年05月16日 16:48 | tkinter doc updates patch | ||
| rename_tkdocs.py | gpolo, 2008年05月16日 16:49 | |||
| remove_libtk_path.diff | gpolo, 2008年05月16日 17:17 | |||
| tkinter_modmerge.diff | gpolo, 2008年05月17日 15:03 | |||
| tkinter_modmerge_py3k.diff | gpolo, 2008年05月17日 19:01 | |||
| Messages (12) | |||
|---|---|---|---|
| msg66747 - (view) | Author: Guilherme Polo (gpolo) * (Python committer) | Date: 2008年05月12日 18:00 | |
I'm moving lib-tk to a tkinter package, I've sent a patch for this which can be found at issue 2775 but I started wrong (did a patch against py3k directly). |
|||
| msg66756 - (view) | Author: Guilherme Polo (gpolo) * (Python committer) | Date: 2008年05月12日 20:43 | |
I've talked with Brett and we agreed on a plan slightly different from the one described in PEP 3108, which seems to be better for tkinter. The first step would be creating a tkinter package and then moving each file in lib-tk to this new directory, correcting imports and the case and renaming Tkinter.py to __init__.py so the directory is marked as a package. After this step I can proceed with more patches, including stub modules, tests in test_py3kwarn and continue with the rest of the plan. I'm attaching two files I've used to do this first step. One is a .py file, which will do the proper renamings and then there is a patch which should be applied to fix imports inside the tkinter package. |
|||
| msg66951 - (view) | Author: Guilherme Polo (gpolo) * (Python committer) | Date: 2008年05月16日 15:44 | |
New patch, this one does the following: * Fix tkinter imports in idlelib, pydoc and Canvas (deprecated) * Creates stub modules for all old Tkinter modules, except tkFileDialog and tkSimpleDialog * Updates test_py3kwarn for all these renames What is missing now: * Merging tkSimpleDialog into tkinter.simpledialog and tkFileDialog into tkinter.filedialog, I believe this should be done using svn merge and then correct the result a bit. * Update docs |
|||
| msg66952 - (view) | Author: Georg Brandl (georg.brandl) * (Python committer) | Date: 2008年05月16日 15:48 | |
Committed step 2 patch as r63376. |
|||
| msg66955 - (view) | Author: Guilherme Polo (gpolo) * (Python committer) | Date: 2008年05月16日 16:48 | |
Patching for updating the docs added. I've also added a script that should be executed after the patch is applied, it will rename scrolledtext.rst to tkinter.scrolledtext.rst; tix.rst to tkinter.rst and turtle.rst to tkinter.turtle.rst. |
|||
| msg66957 - (view) | Author: Guilherme Polo (gpolo) * (Python committer) | Date: 2008年05月16日 17:17 | |
After merging all these changes in py3k, lib-tk should be removed from sys.path there. Patch added for this. Note that the iss script at PC/VS7.1 should be regenerated |
|||
| msg66999 - (view) | Author: Guilherme Polo (gpolo) * (Python committer) | Date: 2008年05月17日 15:03 | |
This new patch handles the merging of tkSimpleDialog into tkinter.simpledialog and tkFileDialog into tkinter.filedialog. After doing it, the old files may be removed from lib-tk: svn del Lib/lib-tk/tkSimpleDialog.py svn del Lib/lib-tk/tkFileDialog.py I will do the stub modules for these modules after the commit then, thanks. |
|||
| msg67000 - (view) | Author: Georg Brandl (georg.brandl) * (Python committer) | Date: 2008年05月17日 15:07 | |
Committed modmerge patch in r63408. |
|||
| msg67010 - (view) | Author: Guilherme Polo (gpolo) * (Python committer) | Date: 2008年05月17日 19:01 | |
Patch added for handling the merging of tkSimpleDialog into tkinter.simpledialog and tkFileDialog into tkinter.filedialog, specific for py3k. |
|||
| msg67012 - (view) | Author: Georg Brandl (georg.brandl) * (Python committer) | Date: 2008年05月17日 19:20 | |
Handled Py3k branch in revs 63417 to 63423. Closing this issue. |
|||
| msg67099 - (view) | Author: Brett Cannon (brett.cannon) * (Python committer) | Date: 2008年05月20日 04:38 | |
The changes in 2.6 need to be reverted, leaving only a note in the docs. |
|||
| msg67109 - (view) | Author: Georg Brandl (georg.brandl) * (Python committer) | Date: 2008年05月20日 07:27 | |
Done in r63485-63491. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:56:34 | admin | set | nosy:
+ barry github: 47088 |
| 2008年05月20日 18:47:49 | brett.cannon | unlink | issue2775 dependencies |
| 2008年05月20日 07:27:21 | georg.brandl | set | status: open -> closed resolution: fixed messages: + msg67109 |
| 2008年05月20日 04:39:04 | brett.cannon | link | issue2775 dependencies |
| 2008年05月20日 04:38:47 | brett.cannon | set | status: closed -> open nosy: + brett.cannon resolution: accepted -> (no value) messages: + msg67099 |
| 2008年05月18日 17:59:39 | brett.cannon | unlink | issue2775 dependencies |
| 2008年05月17日 19:20:20 | georg.brandl | set | status: open -> closed resolution: accepted messages: + msg67012 |
| 2008年05月17日 19:01:22 | gpolo | set | files:
+ tkinter_modmerge_py3k.diff messages: + msg67010 |
| 2008年05月17日 15:07:48 | georg.brandl | set | messages: + msg67000 |
| 2008年05月17日 15:03:47 | gpolo | set | files:
+ tkinter_modmerge.diff messages: + msg66999 |
| 2008年05月16日 17:38:33 | georg.brandl | link | issue2884 superseder |
| 2008年05月16日 17:17:04 | gpolo | set | files:
+ remove_libtk_path.diff messages: + msg66957 |
| 2008年05月16日 16:49:09 | gpolo | set | files: + rename_tkdocs.py |
| 2008年05月16日 16:48:43 | gpolo | set | files:
+ tkinter_doc_updates.diff messages: + msg66955 |
| 2008年05月16日 15:48:48 | georg.brandl | set | nosy:
+ georg.brandl messages: + msg66952 |
| 2008年05月16日 15:44:45 | gpolo | set | files:
+ tkinter_step2.diff messages: + msg66951 |
| 2008年05月16日 04:39:03 | brett.cannon | set | priority: release blocker |
| 2008年05月12日 20:44:42 | gpolo | set | files:
+ tkinter_imports.diff keywords: + patch |
| 2008年05月12日 20:44:05 | gpolo | set | files:
+ tkinter_package.py messages: + msg66756 |
| 2008年05月12日 18:01:08 | gpolo | link | issue2775 dependencies |
| 2008年05月12日 18:00:38 | gpolo | create | |