This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2008年04月24日 13:52 by jimjjewett, last changed 2022年04月11日 14:56 by admin.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| 2679.patch | moijes12, 2012年09月06日 05:33 | Change in patch : NLCRE_crack = NLCRE_bol | review | |
| Messages (2) | |||
|---|---|---|---|
| msg65723 - (view) | Author: Jim Jewett (jimjjewett) | Date: 2008年04月24日 13:52 | |
feedparser defines four regexs for end-of-line, but two are redundant. NLCRE checks for the three common line endings. NLCRE_crack also captures the line ending. NLCRE_eol also adds a $ to ensure it is at the end. NLCRE_bol ... is identical to NLCRE_crack. It should either use a ^ to insist on line-start, or be explicitly the same. (e.g., NLCRE_bol=NLCRE_crack.) (It gets away with not listing the ^ because the current code only uses NLCRE_bol.match. (Actually, if the regexes are considered private, then the current code could just use the bound methods directly ... setting NLCRE_bol to the .match method, NLCRE_eol to the .search method, and NLCRE_crack to the .split method.) |
|||
| msg169904 - (view) | Author: moijes12 (moijes12) | Date: 2012年09月06日 05:36 | |
Hi I've attached a patch. Its a simple one wherein NLCRE_crack = NLCRE_bol. I found this in Python 3.3.0b2+ and so I've added version 3.3. I executed "./python -m test" after making the change and no failures were reported (340-OK, 30-Skip). Looking forward to your comments. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:56:33 | admin | set | github: 46931 |
| 2020年10月25日 23:24:50 | iritkatriel | set | type: behavior -> versions: + Python 3.8, Python 3.9, Python 3.10, - Python 2.6, Python 3.1, Python 2.7, Python 3.2, Python 3.3 |
| 2014年01月05日 05:31:07 | moijes12 | set | nosy:
- moijes12 |
| 2012年09月06日 05:36:58 | moijes12 | set | messages: + msg169904 |
| 2012年09月06日 05:33:35 | moijes12 | set | files:
+ 2679.patch keywords: + patch |
| 2012年09月06日 05:22:16 | moijes12 | set | versions: + Python 3.3 |
| 2012年09月06日 05:12:32 | moijes12 | set | nosy:
+ moijes12 |
| 2010年01月12日 16:49:02 | ezio.melotti | set | nosy:
+ ezio.melotti type: behavior |
| 2010年01月12日 02:54:00 | brian.curtin | set | priority: low stage: needs patch versions: + Python 3.1, Python 2.7, Python 3.2, - Python 3.0 |
| 2008年04月24日 13:52:19 | jimjjewett | create | |