This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2008年04月06日 13:52 by mhammond, last changed 2022年04月11日 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| embed_manifest.patch | mhammond, 2008年04月06日 13:52 | embed the manifest using mt.exe | ||
| Messages (6) | |||
|---|---|---|---|
| msg65034 - (view) | Author: Mark Hammond (mhammond) * (Python committer) | Date: 2008年04月06日 13:52 | |
The move to vs2008 has caused .manifest files to be created next to distutils created extensions modules, rather than being embedded as recommended by Microsoft. See http://msdn2.microsoft.com/en-us/library/ms235591(VS.80).aspx The attached patch achieves this by telling the compiler to generate the manifest in the temp dir, them embeds that manifest using mt.exe Adding Christian for comment (hopefully the correct Christian this time - sorry about that :) |
|||
| msg65160 - (view) | Author: Trent Nelson (trent) * (Python committer) | Date: 2008年04月08日 13:52 | |
+1 from me on principle (haven't tested). |
|||
| msg65164 - (view) | Author: Christian Heimes (christian.heimes) * (Python committer) | Date: 2008年04月08日 14:08 | |
Yes, it's me ;) I'm +1 on the feature but I haven't reviewed your patch. IIRC and unless I'm not mistaken you can tell the linker to embed the manifest without the extra mt.exe dance. |
|||
| msg65218 - (view) | Author: Mark Hammond (mhammond) * (Python committer) | Date: 2008年04月08日 21:13 | |
Note that we are actually using the linker to *generate* the manifest (something linkers pre VC2005 couldn't do), so if we could tell the linker to skip that manifest generation and embed it directly in the DLL, it would certainly be easier. But, IIRC (which I may not), you can embed a manifest directly via the linker by converting the manifest to a resource and linking that - however, that conversion still requires an extra tool. This is the alternative process outlined on the MS page I linked to. And finally, it seems Visual Studio itself embeds the resource this way. So if there is a way to embed the manifest without an additional step, I don't know about it :) |
|||
| msg74724 - (view) | Author: Andre Heider (aheider) | Date: 2008年10月14日 08:14 | |
Note that this patch will break the loading of compiled modules on machines without the MS CRT redistributable installed. See Issue 4120 |
|||
| msg80157 - (view) | Author: Mark Hammond (mhammond) * (Python committer) | Date: 2009年01月19日 10:39 | |
Given bug 4120, this seems the most appropriate resolution... |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:56:33 | admin | set | github: 46815 |
| 2009年01月19日 10:39:23 | mhammond | set | status: open -> closed keywords: patch, patch resolution: out of date messages: + msg80157 |
| 2008年10月14日 08:14:52 | aheider | set | nosy:
+ aheider messages: + msg74724 |
| 2008年04月08日 21:13:36 | mhammond | set | keywords:
patch, patch messages: + msg65218 |
| 2008年04月08日 14:08:35 | christian.heimes | set | keywords:
patch, patch messages: + msg65164 |
| 2008年04月08日 13:52:37 | trent | set | keywords:
patch, patch nosy: + trent messages: + msg65160 |
| 2008年04月06日 13:52:28 | mhammond | create | |