This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2008年03月04日 17:47 by jlt63, last changed 2022年04月11日 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| python.patch | jlt63, 2008年03月04日 17:47 | Remove extra slashes Makefile.pre.in patch | ||
| Makefile.pre.in.diff | jlt63, 2009年01月08日 15:00 | |||
| py-issue-2233.patch | rpetrov, 2009年01月13日 22:12 | shell based solution | review | |
| Makefile.pre.in.v2.diff | jlt63, 2009年01月14日 15:42 | |||
| Messages (12) | |||
|---|---|---|---|
| msg63256 - (view) | Author: Jason Tishler (jlt63) * (Python triager) | Date: 2008年03月04日 17:47 | |
Makefile.pre.in contains extra slash before $(DESTDIR) in two locations as in the following: sharedinstall: $(RUNSHARED) ./$(BUILDPYTHON) -E $(srcdir)/setup.py install \ --prefix=$(prefix) \ --install-scripts=$(BINDIR) \ --install-platlib=$(DESTSHARED) \ --root=/$(DESTDIR) This causes Cygwin builds to fail if DESTDIR is set as follows: creating //tmp error: could not create '//tmp': No such host or network path The following Open Group Specification: http://www.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap04.html indicates the following: 4.11 Pathanme Resolution [snip] A pathname that begins with two successive slashes may be interpreted in an implementation-defined manner,... IMO, these extra slashes should be removed as indicated in the attached patch. OK to commit? If so, to which branches? |
|||
| msg78715 - (view) | Author: Roumen Petrov (rpetrov) * | Date: 2009年01月01日 18:30 | |
I would like to confirm issue for trunk. |
|||
| msg78725 - (view) | Author: Roumen Petrov (rpetrov) * | Date: 2009年01月01日 20:11 | |
I'm not sure that installation work if slash is removed and DESTDIR is not specified. What about to replace "slash before $(DESTDIR)" with "/./" ? |
|||
| msg79413 - (view) | Author: Jason Tishler (jlt63) * (Python triager) | Date: 2009年01月08日 15:00 | |
Sorry for the delay, but I was on vacation and then recovering from vacation... You are correct that my initial patch does not handle the case when DESTDIR is not specified. Your suggestion will work, but seems hacky. What about adding the defaulting of DESTDIR to "/" to my initial patch? This seems cleaner. See my second patch for the details. If this approach is acceptable, then feel free to move the defaulting of DESTDIR to a more appropriate place in Makefile.pre.in. I wasn't sure where to put this change. |
|||
| msg79567 - (view) | Author: Roumen Petrov (rpetrov) * | Date: 2009年01月10日 18:17 | |
Jason, did you test what is result is DESTDIR default to "/". This variable(macro) is used with specific syntax by example (from Makefile): $(INSTALL) -d -m $(DIRMODE) $(DESTDIR)$$b; \ where $$b is absolute path. |
|||
| msg79704 - (view) | Author: Jason Tishler (jlt63) * (Python triager) | Date: 2009年01月12日 21:47 | |
Obviously not... :,( It seems like we might have to go with your "/./" workaround, but let me see if I can come up with another approach. |
|||
| msg79855 - (view) | Author: Jason Tishler (jlt63) * (Python triager) | Date: 2009年01月14日 15:42 | |
Your latest patch is on the right track, but see my latest one, Makefile.pre.in.v2.diff, for an optimization. I tested make install with and without DESTDIR defined on the command line and both cases behaved as expected. |
|||
| msg79874 - (view) | Author: Roumen Petrov (rpetrov) * | Date: 2009年01月14日 20:37 | |
Hi Jason,
quick review without tests - I expect $${DESTDIR:-/} to work without :
in expression, i.e. just $${DESTDIR-/}.
The ":" in expression is not so portable (some shells fail on this).
Please see "Shell Substitutions" in autoconf manual.
|
|||
| msg79877 - (view) | Author: Jason Tishler (jlt63) * (Python triager) | Date: 2009年01月14日 21:58 | |
I guess you mean the following:
${var:-value}
Old BSD shells, including the Ultrix sh, don't accept the colon for
any shell substitution, and complain and die.
If so, should we just go forward without the colon? The bash manpage
indicates the following:
In each of the cases below, ... bash tests for a parameter that is
unset or null; omitting the colon results in a test only for a
parameter that is unset.
So, if a user executes "make DESTDIR= install", then the build will
fail. Or, maybe we shouldn't worry about that corner case.
What do you think?
|
|||
| msg80350 - (view) | Author: Roumen Petrov (rpetrov) * | Date: 2009年01月21日 21:55 | |
No response from py-dev list :( . May be solution has to work in all cases. |
|||
| msg222604 - (view) | Author: Mark Lawrence (BreamoreBoy) * | Date: 2014年07月09日 07:33 | |
Is this still a problem with cygwin? |
|||
| msg222658 - (view) | Author: Jason Tishler (jlt63) * (Python triager) | Date: 2014年07月10日 12:10 | |
AFAICT, yes. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:56:31 | admin | set | github: 46486 |
| 2021年10月21日 09:56:42 | iritkatriel | set | resolution: duplicate -> wont fix |
| 2021年10月20日 12:19:58 | iritkatriel | set | status: open -> closed superseder: Cygwin is unsupported - close all open issues and list them here. resolution: duplicate stage: resolved |
| 2019年04月26日 18:48:13 | BreamoreBoy | set | nosy:
- BreamoreBoy |
| 2014年07月10日 12:10:52 | jlt63 | set | messages: + msg222658 |
| 2014年07月09日 07:33:09 | BreamoreBoy | set | nosy:
+ BreamoreBoy messages: + msg222604 versions: + Python 3.4, Python 3.5, - Python 3.1, Python 3.2 |
| 2010年08月10日 11:40:21 | flox | set | keywords:
patch, patch components: + Windows |
| 2010年08月04日 23:31:34 | terry.reedy | set | keywords:
patch, patch versions: + Python 3.2, - Python 2.6, Python 2.5, Python 3.0 |
| 2009年01月21日 21:55:43 | rpetrov | set | messages: + msg80350 |
| 2009年01月14日 21:58:36 | jlt63 | set | keywords:
patch, patch messages: + msg79877 |
| 2009年01月14日 20:37:27 | rpetrov | set | messages: + msg79874 |
| 2009年01月14日 15:42:16 | jlt63 | set | keywords:
patch, patch files: + Makefile.pre.in.v2.diff messages: + msg79855 |
| 2009年01月13日 22:12:52 | rpetrov | set | files: + py-issue-2233.patch |
| 2009年01月12日 21:47:16 | jlt63 | set | keywords:
patch, patch messages: + msg79704 |
| 2009年01月10日 18:17:37 | rpetrov | set | messages: + msg79567 |
| 2009年01月08日 15:00:05 | jlt63 | set | keywords:
patch, patch files: + Makefile.pre.in.diff messages: + msg79413 |
| 2009年01月01日 20:11:54 | rpetrov | set | messages: + msg78725 |
| 2009年01月01日 18:30:54 | rpetrov | set | nosy:
+ rpetrov messages: + msg78715 versions: + Python 2.6, Python 3.0, Python 3.1, Python 2.7 |
| 2008年03月04日 19:23:09 | jlt63 | set | keywords: patch, patch |
| 2008年03月04日 17:47:50 | jlt63 | create | |